From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932843AbbERU3G (ORCPT ); Mon, 18 May 2015 16:29:06 -0400 Received: from mail.kernel.org ([198.145.29.136]:34717 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932410AbbERU3C (ORCPT ); Mon, 18 May 2015 16:29:02 -0400 Date: Mon, 18 May 2015 17:28:58 -0300 From: Arnaldo Carvalho de Melo To: Alexei Starovoitov Cc: Wang Nan , paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com, namhyung@kernel.org, jolsa@kernel.org, dsahern@gmail.com, daniel@iogearbox.net, brendan.d.gregg@gmail.com, masami.hiramatsu.pt@hitachi.com, lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com Subject: Re: [RFC PATCH v3 02/37] perf tools: Set vmlinux_path__nr_entries to 0 in vmlinux_path__exit Message-ID: <20150518202858.GE18563@kernel.org> References: <1431860222-61636-1-git-send-email-wangnan0@huawei.com> <1431860222-61636-3-git-send-email-wangnan0@huawei.com> <555A1B04.4080104@plumgrid.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <555A1B04.4080104@plumgrid.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, May 18, 2015 at 10:01:56AM -0700, Alexei Starovoitov escreveu: > On 5/17/15 3:56 AM, Wang Nan wrote: > >Original vmlinux_path__exit() doesn't revert vmlinux_path__nr_entries > >to its original state. After the while loop vmlinux_path__nr_entries > >becomes -1 instead of 0. This makes a problem that, if runs twice, > >during the second run vmlinux_path__init() will set vmlinux_path[-1] > >to strdup("vmlinux"), corrupts random memory. > > > >This patch reset vmlinux_path__nr_entries to 0 after the while loop. > > > >Signed-off-by: Wang Nan > >Acked-by: Namhyung Kim > > no need to repost. Arnaldo picked it up already. Yeah, I try to cherry pick stuff that is not related to the main topic of a patchkit and that is an independent bug fix. - Arnaldo > When you repost it many times, it gets very confusing. > If patch is not moving, rather ping it in original thread. > Same with patches 3,4,5.