From: Vinod Koul <vinod.koul@intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: dmaengine@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Modifying sg_dma_len(sg)?
Date: Tue, 19 May 2015 09:31:47 +0530 [thread overview]
Message-ID: <20150519040147.GG3140@localhost> (raw)
In-Reply-To: <CAMuHMdXbxavw3Gw9BbuwVPEFgsY1AOPmRVNq51Xu9_aMrPNZbw@mail.gmail.com>
On Fri, May 15, 2015 at 03:46:27PM +0200, Geert Uytterhoeven wrote:
am ccing LKML, perhaps this needs wider discussion..
> Several drivers reuse mapped scatterlists, and modify sg_dma_len(sg) to
> match the actual number of bytes they want to transfer.
>
> Hence during driver shutdown, dma_unmap_sg() is called with a scatterlist
> that has modified lengths, compared to the original passed to dma_map_sg().
> If CONFIG_DMA_API_DEBUG=y, this causes warnings like:
>
> WARNING: CPU: 0 PID: 20 at lib/dma-debug.c:1103 check_unmap+0x24c/0x85c()
> rcar-dmac e6700000.dma-controller: DMA-API: device driver frees
> DMA memory with different size [device address=0x000000006e15f000]
> [map size=4096 bytes] [unmap size=3 bytes]
>
> The warning can be silenced by restoring the original sg_dma_len() just before
> calling dma_unmap_sg(), but it looks like no driver actually does that.
Right, but should the drivers map with one length and then modify the
length later on, why not map only the size that is required...
So driver should always unmap and remap with the right length whenever it is
required to change the length. Perhaps a dma_remap_sg() API to do so
properly.
I do not think modifying length directly should be encouraged...
--
~Vinod
>
> Is it allowed to modify sg_dma_len(sg)?
> Is it OK to restore the original sg_dma_len()?
>
> Thanks for your answers!
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
next parent reply other threads:[~2015-05-19 4:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAMuHMdXbxavw3Gw9BbuwVPEFgsY1AOPmRVNq51Xu9_aMrPNZbw@mail.gmail.com>
2015-05-19 4:01 ` Vinod Koul [this message]
2015-05-19 6:51 ` Modifying sg_dma_len(sg)? Geert Uytterhoeven
2015-05-21 15:53 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519040147.GG3140@localhost \
--to=vinod.koul@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).