From: Vinod Koul <vinod.koul@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: "hch@lst.de" <hch@lst.de>, "axboe@fb.com" <axboe@fb.com>,
"mingo@kernel.org" <mingo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"j.glisse@gmail.com" <j.glisse@gmail.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"riel@redhat.com" <riel@redhat.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"willy@linux.intel.com" <willy@linux.intel.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"mgorman@suse.de" <mgorman@suse.de>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"david@fromorbit.com" <david@fromorbit.com>
Subject: Re: [PATCH v3 06/11] scatterlist: support "page-less" (__pfn_t only) entries
Date: Tue, 19 May 2015 09:40:52 +0530 [thread overview]
Message-ID: <20150519041052.GI3140@localhost> (raw)
In-Reply-To: <1431542149.31415.10.camel@intel.com>
On Wed, May 13, 2015 at 06:35:55PM +0000, Williams, Dan J wrote:
> [ adding willy (yes, need to fix my scripts), and dmaengine folks]
>
> Jens, Christoph,
>
> I've rebased this patch series block/for-next. With commit 84be456f883c
> "remove <asm/scatterlist.h>" I think we can take the next step of
> removing all references to page_link and just use __pfn_t by default.
> v4 patch below.
>
> Jens, I'm wondering if you want to take this series(.) as patches or
> prepare a git branch to pull?
>
> diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
> index 4d63e0d4da9a..21736afd3320 100644
> --- a/drivers/crypto/omap-sham.c
> +++ b/drivers/crypto/omap-sham.c
> @@ -582,7 +582,7 @@ static int omap_sham_xmit_dma(struct omap_sham_dev *dd, dma_addr_t dma_addr,
> * the dmaengine may try to DMA the incorrect amount of data.
> */
> sg_init_table(&ctx->sgl, 1);
> - ctx->sgl.page_link = ctx->sg->page_link;
> + ctx->sgl.pfn = ctx->sg->pfn;
Do you want drivers to tinker with internals of sg, I think driver should be
agnostic here, perhpas a helper to get pfn, sg_get_pfn()
> ctx->sgl.offset = ctx->sg->offset;
> sg_dma_len(&ctx->sgl) = len32;
> sg_dma_address(&ctx->sgl) = sg_dma_address(ctx->sg);
> diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
> index eed405976ea9..a767727bcfef 100644
> --- a/drivers/dma/imx-dma.c
> +++ b/drivers/dma/imx-dma.c
> @@ -886,7 +886,7 @@ static struct dma_async_tx_descriptor *imxdma_prep_dma_cyclic(
> sg_init_table(imxdmac->sg_list, periods);
>
> for (i = 0; i < periods; i++) {
> - imxdmac->sg_list[i].page_link = 0;
> + imxdmac->sg_list[i].pfn.page = NULL;
same here, sg_set_pfn_page() ?
> imxdmac->sg_list[i].offset = 0;
> imxdmac->sg_list[i].dma_address = dma_addr;
> sg_dma_len(&imxdmac->sg_list[i]) = period_len;
> @@ -894,10 +894,7 @@ static struct dma_async_tx_descriptor *imxdma_prep_dma_cyclic(
> }
>
> /* close the loop */
> - imxdmac->sg_list[periods].offset = 0;
> - sg_dma_len(&imxdmac->sg_list[periods]) = 0;
> - imxdmac->sg_list[periods].page_link =
> - ((unsigned long)imxdmac->sg_list | 0x01) & ~0x02;
> + sg_chain(imxdmac->sg_list, periods + 1, imxdmac->sg_list);
This looks right...
--
~Vinod
next prev parent reply other threads:[~2015-05-19 4:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 4:29 [PATCH v3 00/11] evacuate struct page from the block layer, introduce __pfn_t Dan Williams
2015-05-12 4:29 ` [PATCH v3 01/11] arch: introduce __pfn_t for persistenti/device memory Dan Williams
2015-05-12 4:29 ` [PATCH v3 02/11] block: add helpers for accessing a bio_vec page Dan Williams
2015-05-12 4:29 ` [PATCH v3 03/11] block: convert .bv_page to .bv_pfn bio_vec Dan Williams
2015-05-12 4:29 ` [PATCH v3 04/11] dma-mapping: allow archs to optionally specify a ->map_pfn() operation Dan Williams
2015-05-12 4:29 ` [PATCH v3 05/11] scatterlist: use sg_phys() Dan Williams
2015-05-12 5:24 ` Julia Lawall
2015-05-12 5:44 ` Dan Williams
2015-05-12 4:30 ` [PATCH v3 06/11] scatterlist: support "page-less" (__pfn_t only) entries Dan Williams
2015-05-13 18:35 ` Williams, Dan J
2015-05-19 4:10 ` Vinod Koul [this message]
2015-05-20 16:03 ` Dan Williams
2015-05-23 14:12 ` hch
2015-05-23 16:41 ` Dan Williams
2015-05-12 4:30 ` [PATCH v3 07/11] x86: support dma_map_pfn() Dan Williams
2015-05-12 4:30 ` [PATCH v3 08/11] x86: support kmap_atomic_pfn_t() for persistent memory Dan Williams
2015-05-12 4:30 ` [PATCH v3 09/11] block: convert kmap helpers to kmap_atomic_pfn_t() Dan Williams
2015-05-12 4:30 ` [PATCH v3 10/11] dax: convert to __pfn_t Dan Williams
2015-05-12 4:30 ` [PATCH v3 11/11] block: base support for pfn i/o Dan Williams
2015-05-23 14:32 ` [PATCH v3 00/11] evacuate struct page from the block layer, introduce __pfn_t Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519041052.GI3140@localhost \
--to=vinod.koul@intel.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=dmaengine@vger.kernel.org \
--cc=hch@lst.de \
--cc=j.glisse@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=riel@redhat.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).