From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754354AbbESHnu (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 May 2015 03:43:50 -0400
Received: from mail.kernel.org ([198.145.29.136]:35002 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753752AbbESHnr (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 May 2015 03:43:47 -0400
Date: Tue, 19 May 2015 15:43:14 +0800
From: Shawn Guo <shawnguo@kernel.org>
To: Heiko Schocher <hs@denx.de>
Cc: linux-kernel@vger.kernel.org, Shawn Guo <shawn.guo@linaro.org>,
        Sascha Hauer <kernel@pengutronix.de>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v2] arm, imx6, dts: add DT for aristainetos2 board
Message-ID: <20150519074314.GT1071@dragon>
References: <1431334974-27531-1-git-send-email-hs@denx.de>
 <20150518113135.GD1071@dragon>
 <555AE192.8010700@denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <555AE192.8010700@denx.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 19, 2015 at 09:09:06AM +0200, Heiko Schocher wrote:
> >>@@ -0,0 +1,124 @@
> >>+/*
> >>+ * support fot the imx6 based aristainetos2 board
> >>+ *
> >>+ * Copyright (C) 2015 Heiko Schocher <hs@denx.de>
> >>+ *
> >>+ * This program is free software; you can redistribute it and/or modify
> >>+ * it under the terms of the GNU General Public License version 2 as
> >>+ * published by the Free Software Foundation.
> >>+ *
> >>+ */
> >
> >GPL/X11 dual licence is suggested for new DTS files.  See
> >arch/arm/boot/dts/imx6sl-warp.dts for an example.
> 
> Ok, I ask the customer, if this is OK for him ...

The dual license get non-Linux users be able to use the DTS file.

[...]

> >>+&i2c3 {
> >>+	atmel: atmel_mxt_ts@4b {
> >
> >Node name should be generic.
> 
> So, what name do you prefer?

The node name with the example in bindings doc
Documentation/devicetree/bindings/input/atmel,maxtouch.txt seems
perfectly fine to me.

[...]

> >>+&i2c3 {
> >>+	atmel: atmel_mxt_ts@4d {
> >>+		compatible = "atmel,maxtouch";
> >>+		reg = <0x4d>;
> >>+		interrupt-parent = <&gpio2>;
> >>+		interrupts = <9 8>;
> >>+	};
> >
> >It seems the touch device is identical between
> >imx6dl-aristainetos2_4.dts and imx6dl-aristainetos2_7.dts.  Why don't
> >you put it into imx6qdl-aristainetos2.dtsi?
> 
> They have different i2c addresses ...

Okay, I missed that.

Shawn