From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755561AbbESI6P (ORCPT ); Tue, 19 May 2015 04:58:15 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:34828 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753146AbbESI6I (ORCPT ); Tue, 19 May 2015 04:58:08 -0400 Date: Tue, 19 May 2015 09:58:05 +0100 From: Matt Fleming To: Thomas Gleixner Cc: LKML , Peter Zijlstra , Vikas Shivappa , x86@kernel.org, Matt Fleming , Will Auld , Kanaka Juvva Subject: Re: [patch 2/6] x86, perf, cqm: Use proper data type Message-ID: <20150519085805.GA17401@codeblueprint.co.uk> References: <20150518234114.574556332@linutronix.de> <20150518235149.919350144@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150518235149.919350144@linutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 May, at 12:00:51AM, Thomas Gleixner wrote: > int is really not a proper data type for a MSR. Use u32 to make it > clear that we are dealing with a 32bit unsigned hardware value. > > Signed-off-by: Thomas Gleixner > --- > arch/x86/kernel/cpu/perf_event_intel_cqm.c | 4 ++-- > include/linux/perf_event.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Yeah, makes sense, but this is missing a bunch of changes to other functions that pass rmids around. Lemme take a swing at that. -- Matt Fleming, Intel Open Source Technology Center