From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932249AbbESMJY (ORCPT ); Tue, 19 May 2015 08:09:24 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47107 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751903AbbESMJV (ORCPT ); Tue, 19 May 2015 08:09:21 -0400 Date: Tue, 19 May 2015 13:09:15 +0100 From: Mark Brown To: "Zha, Qipeng" Cc: "linux-kernel@vger.kernel.org" , "Yang, Fei" , "Zhong, Huiquan" , "Chen, Jason CJ" , "Zheng, Qi" Message-ID: <20150519120915.GJ2761@sirena.org.uk> References: <1429573138-68002-1-git-send-email-qipeng.zha@intel.com> <20150518112109.GZ2761@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oUPnJK6bvWWzFkJy" Content-Disposition: inline In-Reply-To: X-Cookie: 13. ... r-q1 User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regmap: add virtual PMIC IPC bus support X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --oUPnJK6bvWWzFkJy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 19, 2015 at 04:57:00AM +0000, Zha, Qipeng wrote: > >Why is this being added to the regmap core rather than being implemented > >in using the reg_write() and reg_read() callbacks in the core driver for > >the PMIC? > Thanks. I don't receive this message before in eamil. > Current regmap only support register access using several bus: i2c, spi, ac97 ... > But register access for intel pmic are done by hardware ipc, so we add such support in regmap core, > To make pmic subdevice drivers can use generic regmap r/w API to access registers. That doesn't really address my concern - we already have the reg_read() and reg_write() interface so devices can use regmap without a bus in the core. The question is if this is something that's going to be used by many devices so there's code to share or if it's something that's only going to be used by this PMIC in which case keeping it in the driver should be easier. --oUPnJK6bvWWzFkJy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVWyfqAAoJECTWi3JdVIfQvRMH/1U8SLGeyzZNQUXz/aQ5peUv 0q7acRajcZUD7QekBKie9xY7sNH0Vm3Hj46S3XY1UcpC8r8iHXxfMXfzu9nVzWYT VcvEJFlEFBirNF9aexWF6/UWtNYOMq6WY+hMtrrWiR4FoefNO1MYa2pfGUzBs5zI 6uVaiWr3v8KIy1G/XVTTuPtcEnlVAz0xC30eENDfNaY2hA3fmdW8omOkPiutxCo1 ppzhxqX6hA20AExnajr4EOqomCgFU5MlIYdsYmel3Xct+4uJoyaDfZMq+CC3HcW5 ChYm3yAbwcrBR/+y1o60s0fWiArZ5KjfRMLv8PVDAzcgcxWe1zxtR3ImqS8Nmxw= =Eqm5 -----END PGP SIGNATURE----- --oUPnJK6bvWWzFkJy--