From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756558AbbESQTT (ORCPT ); Tue, 19 May 2015 12:19:19 -0400 Received: from the.earth.li ([46.43.34.31]:45380 "EHLO the.earth.li" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756337AbbESQTO (ORCPT ); Tue, 19 May 2015 12:19:14 -0400 Date: Tue, 19 May 2015 17:19:11 +0100 From: Jonathan McDowell To: Takashi Iwai Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: Audio crackles with 4.1-rc1 Message-ID: <20150519161911.GD28070@earth.li> References: <20150428123518.GU10148@earth.li> <20150429112859.GY10148@earth.li> <20150430150131.GA10148@earth.li> <20150502150513.GF10148@earth.li> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2015 at 08:15:32AM +0200, Takashi Iwai wrote: > At Sat, 2 May 2015 16:05:13 +0100, > Jonathan McDowell wrote: > > > > On Thu, Apr 30, 2015 at 07:06:31PM +0200, Takashi Iwai wrote: > > > At Thu, 30 Apr 2015 16:01:31 +0100, Jonathan McDowell wrote: > > > > > > > > On Wed, Apr 29, 2015 at 01:54:57PM +0200, Takashi Iwai wrote: > > > > > > > > > > One patch you can try (with or without power_save_node > > > > > disablement) is below, it squashes the verb sequences at (runtime) > > > > > PM resume as we did for 4.0. Let me know if this changes the > > > > > behavior. > > > > > > > > Patch alone has no effect. Patch with power_save_node disablement > > > > solves the problem. Didn't try power_save_node disablement without > > > > the patch. > > > > > > Then please confirm that only power_save_node disablement suffices. > > > This can be considered as the least change that can be put to 4.1-rc > > > if no better fix is found. > > > > Setting codec->power_save_node to 0 in patch_alc269 is sufficient; no > > noticeable cracking occurring. > > Does the patch below have any improvement? I still get a clicking on the standby -> active transition with the patch provided on top of 4.1-rc4. J. -- 101 things you can't have too | .''`. Debian GNU/Linux Developer much of : 9 - Processing power. | : :' : Happy to accept PGP signed | `. `' or encrypted mail - RSA | `- key on the keyservers.