Re: [RFC] block: remove never-modified global variable

From: Brian Norris <computersforpeace@gmail.com>
To: Boaz Harrosh <boaz@plexistor.com>
Cc: Jens Axboe <axboe@fb.com>,
	linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [RFC] block: remove never-modified global variable
Date: Tue, 19 May 2015 10:58:37 -0700	[thread overview]
Message-ID: <20150519175837.GX11598@ld-irv-0074> (raw)
In-Reply-To: <20150519175532.GW11598@ld-irv-0074>

On Tue, May 19, 2015 at 10:55:32AM -0700, Brian Norris wrote:
> On Tue, May 19, 2015 at 10:34:56AM +0300, Boaz Harrosh wrote:
> > boaz> So by this stage res can only be == 0. So we should just do:
> > 
> >  	if (err)
> > 	/* The partition is unrecognized. So report I/O errors if there were any */
> > -		res = err;
> 
> ^^ You don't want to kill this line, since we still return ERR_PRT(res).
> But otherwise, I think you're right.
> 
> > -	if (res) {
> > -		strlcat(state->pp_buf,
> > -			" unable to read partition table\n", PAGE_SIZE);
> > -		printk(KERN_INFO "%s", state->pp_buf);
> > -	}
> > +		printk(KERN_INFO "%s unable to read partition table\n",
> > +		       state->pp_buf);
> >  
> >  	free_page((unsigned long)state->pp_buf);
> >  	free_partitions(state);
> >  	return ERR_PTR(res);

Or rather, just make the above line:

	return ERR_PTR(err);

> >  }

Brian