From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751911AbbETDLo (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 May 2015 23:11:44 -0400
Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.227]:61087 "EHLO
	cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751085AbbETDLn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 May 2015 23:11:43 -0400
Date: Tue, 19 May 2015 23:12:02 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
        yrl.pp-manager.tt@hitachi.com,
        Aaron Fabbri <aaronx.j.fabbri@intel.com>, linux-kernel@vger.kernel.org,
        Divya Vyas <edivya.vyas@gmail.com>
Subject: Re: [PATCH trace-cmd V5 2/6] trace-cmd/listen: Introduce trace-msg
 protocol (protocol v2)
Message-ID: <20150519231202.35614532@grimm.local.home>
In-Reply-To: <20141222174750.10068.41354.stgit@localhost.localdomain>
References: <20141222174736.10068.90306.stgit@localhost.localdomain>
	<20141222174750.10068.41354.stgit@localhost.localdomain>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-RR-Connecting-IP: 107.14.168.118:25
X-Cloudmark-Score: 0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 22 Dec 2014 12:47:50 -0500
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:

> Introduce new trace-msg protocol (protocol V2) for more
> flexible messaging. V1 protocol which is currently used
> by trace-cmd server and client, is based on a simple
> text messages. It is impossible to extend the protocol
> without breaking backward compatibility. The V2 protocol
> introduced by this patch is a binary message-based protocol
> and it is able to extend by just adding message tags.
> 
> <How to test>
> [1] Backward compatibility checks
>  We need to test backward compatibility of this patch for old
>  trace-cmds(client/server). So, this patch was tested for [2]
>  command checks in following 3 types:
> 
> 	<client>	<server>
> 	  new		  old
> 	  old		  new
> 	  new		  new
> 
> [2] Command checks
> - server (common)
> 	# trace-cmd listen -p 12345
> 
> 1) record
> - client
> 	# trace-cmd record -e sched -N <server IP>:12345
> 	^C
> 
> 2) record + multiple buffers
> - client
> 	# trace-cmd record -B foo -e sched -N <server IP>:12345
> 	^C
> 
> 3) extract
> - client
> 	# ./trace-cmd start -e sched
> 	# sleep 5
> 	# ./trace-cmd stop
> 	# ./trace-cmd extract -N <server IP>:12345
> 
> 4) extract + snapshot
> - client
> 	# ./trace-cmd start -e sched
> 	# sleep 5
> 	# ./trace-cmd snapshot -s
> 	# ./trace-cmd stop
> 	# ./trace-cmd extract -N <server IP>:12345 -s
> 
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>

Hi Masami,

Is this a rewrite of Yoshihiro's work? I would like to keep the From:
from him if he did the initial work, and add both of your
signed-off-bys.

Note, I did pull in some of his patches to a temp branch and extended
on them. I'll look to see if I have to modify this code as well.

Thanks!

-- Steve