From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751716AbbETFBa (ORCPT ); Wed, 20 May 2015 01:01:30 -0400 Received: from mail.kernel.org ([198.145.29.136]:60643 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbbETFB2 (ORCPT ); Wed, 20 May 2015 01:01:28 -0400 Date: Tue, 19 May 2015 22:01:25 -0700 From: Jaegeuk Kim To: "Theodore Ts'o" , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH 3/4] f2fs crypto: check encryption for tmpfile Message-ID: <20150520050125.GB56982@jaegeuk-mac02.hsd1.ca.comcast.net> References: <1432082606-55975-1-git-send-email-jaegeuk@kernel.org> <1432082606-55975-3-git-send-email-jaegeuk@kernel.org> <20150520044604.GD2871@thunk.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150520044604.GD2871@thunk.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 20, 2015 at 12:46:04AM -0400, Theodore Ts'o wrote: > On Tue, May 19, 2015 at 05:43:25PM -0700, Jaegeuk Kim wrote: > > This patch adds to check encryption for tmpfile in early stage. > > Don't you also need a call to ext4_inherit_context(dir, inode) here? > (I need to fix this for ext4 as well). Actually this should be: err = f2fs_get_encryption_info(inode); <- for inode. if (err) goto out; In f2fs, f2fs_do_tmpfile calls f2fs_inherit_context already. :) > > - Ted