From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754293AbbETS6P (ORCPT ); Wed, 20 May 2015 14:58:15 -0400 Received: from smtprelay0222.hostedemail.com ([216.40.44.222]:39743 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754235AbbETS6M (ORCPT ); Wed, 20 May 2015 14:58:12 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 40,2.5,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::,RULES_HIT:41:355:379:421:541:599:800:960:973:981:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2691:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3872:3873:3874:4250:5007:6261:6742:7875:8603:10011:10400:10848:10967:11232:11658:11914:12517:12519:12740:13069:13161:13229:13311:13357:13972:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:1:0 X-HE-Tag: bulb70_2a092fff32d56 X-Filterd-Recvd-Size: 2013 Date: Wed, 20 May 2015 14:58:07 -0400 From: Steven Rostedt To: Stephen Boyd Cc: Ankit Gupta , gavidov@codeaurora.org, sdharia@codeaurora.org, mlocke@codeaurora.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, ivan.ivanov@linaro.org, linux-kernel@vger.kernel.org, svarbanov@mm-sol.com, galak@codeaurora.org, agross@codeaurora.org Subject: Re: [PATCH] spmi: add command tracepoints for SPMI Message-ID: <20150520145807.63f62ca7@gandalf.local.home> In-Reply-To: <20150520182955.GR31753@codeaurora.org> References: <1431985887-23379-1-git-send-email-ankgupta@codeaurora.org> <555BD719.80508@codeaurora.org> <20150520090808.36cf77c2@ankgupta-lnx.qualcomm.com> <20150520182955.GR31753@codeaurora.org> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 May 2015 11:29:55 -0700 Stephen Boyd wrote: > > I see no reason to spend to 4-8 bytes when spmi spec allows for maximum > > buffer size of 16. Do you suggest changing the API of read_cmd()? > > > > > Is that a maximum buffer size of 16 bytes? I'd prefer consistency > with the API that's being traced, that's all. Changing it to u8 > to save a few bytes probably doesn't make any difference if the > architecture passes function arguments in CPU registers which are > 32 or 64 bits wide or if the function can be inlined enough by > the compiler to where the len parameter is kept in a register. > I believe the worry is about wasting bytes in the ring buffer if not necessary. But we do that in other tracepoints, so it's really up to the maintainer. -- Steve