From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161049AbbEUVXi (ORCPT ); Thu, 21 May 2015 17:23:38 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:39963 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161000AbbEUVXh (ORCPT ); Thu, 21 May 2015 17:23:37 -0400 Date: Thu, 21 May 2015 17:23:35 -0400 (EDT) Message-Id: <20150521.172335.2013762602695904530.davem@davemloft.net> To: joe@perches.com Cc: harish.patil@qlogic.com, sudarsana.kalluru@qlogic.com, Dept-GELinuxNICDev@qlogic.com, linux-driver@qlogic.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] qlge: Move jiffies_to_usecs immediately before loop From: David Miller In-Reply-To: <1432097092.2870.266.camel@perches.com> References: <1432097092.2870.266.camel@perches.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 May 2015 14:23:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Perches Date: Tue, 19 May 2015 21:44:52 -0700 > 30 usecs (or really, 1 jiffy) can go by pretty fast. > > Move the set of the timeout immediately before the loop. > > Remove the unnecessary max(1ul, usecs_to_jiffies(30)) as > usecs_to_jiffies with a non-zero constant is guaranteed > to be non-zero. > > Signed-off-by: Joe Perches This looks fine, applied to net-next, thanks Joe.