From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755664AbbEUPFW (ORCPT ); Thu, 21 May 2015 11:05:22 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:33885 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754889AbbEUPFO (ORCPT ); Thu, 21 May 2015 11:05:14 -0400 Date: Thu, 21 May 2015 18:04:59 +0300 From: Dan Carpenter To: Jan Kara Cc: Fabian Frederick , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] udf: fix udf_load_pvoldesc() Message-ID: <20150521150459.GH4150@mwanda> References: <20150520081315.GA21948@mwanda> <20150521132156.GG27863@quack.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150521132156.GG27863@quack.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 21, 2015 at 03:21:56PM +0200, Jan Kara wrote: > On Wed 20-05-15 11:13:15, Dan Carpenter wrote: > > There are some missing braces here which means this function never > > succeeds. > > > > Fixes: e9d4cf411f75 ('udf: improve error management in udf_CS0toUTF8()') > > Signed-off-by: Dan Carpenter > Thanks for the patch. Added to my tree. Actually, the missing parenthesis > don't cause any real issues since almost all volumes have volIdent and thus > ret gets set to 0 in the previous if. But it's certainly good to fix. Ah... I didn't read carefully. Thanks. regards, dan carpenter