From: Thierry Reding <thierry.reding@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kevin Hilman <khilman@kernel.org>,
Scot Doyle <lkml14@scotdoyle.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Jiri Slaby <jslaby@suse.cz>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Pavel Machek <pavel@ucw.cz>,
Geert Uytterhoeven <geert@linux-m68k.org>,
lkml <linux-kernel@vger.kernel.org>,
linux-fbdev@vger.kernel.org, linux-man@vger.kernel.org,
linux-api@vger.kernel.org, Tyler Baker <tyler.baker@linaro.org>,
Olof Johansson <olof@lixom.net>,
Daniel Stone <daniel@fooishbar.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2 2/3] fbcon: use the cursor blink interval provided by vt
Date: Fri, 22 May 2015 12:00:03 +0200 [thread overview]
Message-ID: <20150522100002.GB16507@ulmo> (raw)
In-Reply-To: <20150522020031.GA3516@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 4661 bytes --]
On Thu, May 21, 2015 at 07:00:31PM -0700, Greg Kroah-Hartman wrote:
> On Thu, May 21, 2015 at 10:00:50AM +0200, Thierry Reding wrote:
> > On Wed, May 20, 2015 at 09:26:38PM -0700, Greg Kroah-Hartman wrote:
> > > On Wed, May 20, 2015 at 02:36:17PM +0200, Thierry Reding wrote:
> > > > On Tue, May 19, 2015 at 04:41:12PM -0700, Greg Kroah-Hartman wrote:
> > > > > On Tue, May 19, 2015 at 11:52:29PM +0200, Thierry Reding wrote:
> > > > > > On Tue, May 19, 2015 at 02:45:19PM -0700, Kevin Hilman wrote:
> > > > > > > On Tue, May 19, 2015 at 2:40 PM, Thierry Reding
> > > > > > > <thierry.reding@gmail.com> wrote:
> > > > > > > > On Tue, May 19, 2015 at 02:15:41PM -0700, Kevin Hilman wrote:
> > > > > > > >> On Thu, Mar 26, 2015 at 6:56 AM, Scot Doyle <lkml14@scotdoyle.com> wrote:
> > > > > > > >> > vt now provides a cursor blink interval via vc_data. Use this
> > > > > > > >> > interval instead of the currently hardcoded 200 msecs. Store it in
> > > > > > > >> > fbcon_ops to avoid locking the console in cursor_timer_handler().
> > > > > > > >> >
> > > > > > > >> > Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
> > > > > > > >> > Acked-by: Pavel Machek <pavel@ucw.cz>
> > > > > > > >>
> > > > > > > >> This patch hit next-20150519 in the form of commit 27a4c827c34a
> > > > > > > >> (fbcon: use the cursor blink interval provided by vt) and has caused
> > > > > > > >> boot failure on a handful of ARM platforms when booting a MMC root
> > > > > > > >> filesystem. This error was spotted by the kernelci.org bot on
> > > > > > > >> exynos5800-peach-pi[1] and Thierry and Daniel (Cc'd) have seen it on
> > > > > > > >> some tegra platforms too.
> > > > > > > >>
> > > > > > > >> Thierry spotted this commit as a potential cause, and both Daniel and
> > > > > > > >> I have reverted and boot tested on exynos5 and tegra respectively and
> > > > > > > >> the boot panics disappear.
> > > > > > > >
> > > > > > > > FWIW, if I apply the below on top of next-20150519 things seem to be
> > > > > > > > back to normal as well:
> > > > > > > >
> > > > > > > > diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> > > > > > > > index 05b1d1a71ef9..658c34bb9076 100644
> > > > > > > > --- a/drivers/video/console/fbcon.c
> > > > > > > > +++ b/drivers/video/console/fbcon.c
> > > > > > > > @@ -1310,8 +1310,9 @@ static void fbcon_cursor(struct vc_data *vc, int mode)
> > > > > > > > return;
> > > > > > > >
> > > > > > > > ops->cur_blink_jiffies = msecs_to_jiffies(vc->vc_cur_blink_ms);
> > > > > > > > - fbcon_del_cursor_timer(info);
> > > > > > > > - if (!(vc->vc_cursor_type & 0x10))
> > > > > > > > + if (vc->vc_cursor_type & 0x10)
> > > > > > > > + fbcon_del_cursor_timer(info);
> > > > > > > > + else
> > > > > > > > fbcon_add_cursor_timer(info);
> > > > > > > >
> > > > > > > > ops->cursor_flash = (mode == CM_ERASE) ? 0 : 1;
> > > > > > >
> > > > > > > Applying this on next-20150519 makes my exynos board happily boot again as well.
> > > > > > >
> > > > > > > Tested-by: Kevin Hilman <khilman@linaro.org>
> > > > > >
> > > > > > Excellent. Greg, Scot, any opinions on whether or not this is the right
> > > > > > thing to do? It restores a bit that looks suspiciously like it snuck in
> > > > > > in the original (at least it isn't documented in the commit message).
> > > > > >
> > > > > > Greg, feel free to squash this in if everybody agrees this is good to
> > > > > > go. If you prefer a patch on top let me know and I'll come up with a
> > > > > > proper commit message.
> > > > >
> > > > > Please send a real patch and I'll apply it on top, as I can't rebase my
> > > > > public tree.
> > > >
> > > > Attached.
> > >
> > > Ugh, no, please resend it as a stand-alone patch, I can't easily apply
> > > attachments.
> >
> > Really? Your MUA can't dissect multipart messages? Anyway, sent
> > separately for your convenience.
>
> "git am" doesn't do that. I apply patches in huge chunks of mbox files.
What I frequently end up doing is apply patches straight from mutt by
piping the mail or an attached patch to git am. I guess I had expected
that you'd have something similar to simplify applying patches.
> Remember, if I have to hand-edit, or do something special with your
> patch, I will not do it, you need to do it correctly to make
> maintainer's lives easier, not harder, given that maintainers are the
> limited resouce, not developers.
I understand. I'll make a mental note to never send you patches as
attachment again.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-05-22 10:00 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 20:37 [PATCH v3 0/2] fbcon: user-defined cursor blink interval Scot Doyle
2015-01-26 20:40 ` [PATCH v3 1/2] fbcon: store cursor blink interval in fbcon_ops Scot Doyle
2015-01-26 20:41 ` [PATCH v3 2/2] fbcon: expose cursor blink interval via sysfs Scot Doyle
2015-01-26 20:54 ` Richard Weinberger
2015-02-25 9:49 ` Pavel Machek
2015-02-25 23:32 ` [PATCH " Scot Doyle
2015-02-26 22:02 ` Pavel Machek
2015-02-27 19:10 ` [PATCH 0/2] add cursor blink interval terminal escape sequence Scot Doyle
2015-02-27 19:13 ` [PATCH 1/2] vt: add cursor blink interval " Scot Doyle
2015-03-14 17:48 ` Scot Doyle
2015-03-25 11:19 ` Greg Kroah-Hartman
2015-03-26 13:51 ` [PATCH v2 0/3] add cursor blink interval terminal " Scot Doyle
2015-03-26 13:54 ` [PATCH v2 1/3] vt: add cursor blink interval " Scot Doyle
2015-03-28 0:35 ` Mike Frysinger
2015-03-28 7:50 ` Pavel Machek
2015-03-26 13:56 ` [PATCH v2 2/3] fbcon: use the cursor blink interval provided by vt Scot Doyle
2015-05-19 21:15 ` Kevin Hilman
2015-05-19 21:40 ` Thierry Reding
2015-05-19 21:45 ` Kevin Hilman
2015-05-19 21:52 ` Thierry Reding
2015-05-19 23:41 ` Greg Kroah-Hartman
2015-05-20 12:36 ` Thierry Reding
2015-05-21 4:26 ` Greg Kroah-Hartman
2015-05-21 8:00 ` Thierry Reding
2015-05-22 2:00 ` Greg Kroah-Hartman
2015-05-22 10:00 ` Thierry Reding [this message]
2015-05-22 10:33 ` Arnd Bergmann
2015-05-22 11:49 ` Thierry Reding
2015-05-22 13:07 ` Silvan Jegen
2015-05-22 13:24 ` Arnd Bergmann
2015-05-22 14:41 ` Thierry Reding
2015-05-22 14:32 ` Greg Kroah-Hartman
2015-05-22 14:44 ` Thierry Reding
2015-05-20 0:36 ` Scot Doyle
2015-03-26 13:57 ` [PATCH v2 3/3] console_codes.4: Add CSI sequence for cursor blink interval Scot Doyle
2015-03-28 7:51 ` Pavel Machek
2015-07-05 17:41 ` Scot Doyle
2015-07-21 16:55 ` Michael Kerrisk (man-pages)
2015-07-21 18:45 ` Scot Doyle
2015-03-28 7:54 ` [PATCH v2 0/3] add cursor blink interval terminal escape sequence Pavel Machek
2015-05-10 13:32 ` Greg Kroah-Hartman
2015-02-27 19:15 ` [PATCH 2/2] fbcon: use the cursor blink interval provided by vt Scot Doyle
2015-05-27 5:57 ` Andrey Wagin
2015-05-27 7:52 ` Scot Doyle
2015-05-27 11:07 ` Andrey Wagin
2015-03-02 11:15 ` [PATCH 0/2] add cursor blink interval terminal escape sequence Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150522100002.GB16507@ulmo \
--to=thierry.reding@gmail.com \
--cc=arnd@arndb.de \
--cc=daniel@fooishbar.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=khilman@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=lkml14@scotdoyle.com \
--cc=mtk.manpages@gmail.com \
--cc=olof@lixom.net \
--cc=pavel@ucw.cz \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
--cc=tyler.baker@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).