From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946381AbbEVRYe (ORCPT ); Fri, 22 May 2015 13:24:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35075 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946360AbbEVRY2 (ORCPT ); Fri, 22 May 2015 13:24:28 -0400 Date: Fri, 22 May 2015 19:23:33 +0200 From: Jiri Olsa To: Wang Nan Cc: paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, jolsa@kernel.org, dsahern@gmail.com, ast@plumgrid.com, daniel@iogearbox.net, brendan.d.gregg@gmail.com, masami.hiramatsu.pt@hitachi.com, lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com Subject: Re: [RFC PATCH v3 09/37] bpf tools: Open eBPF object file and do basic validation Message-ID: <20150522172333.GE6609@krava.redhat.com> References: <1431860222-61636-1-git-send-email-wangnan0@huawei.com> <1431860222-61636-10-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431860222-61636-10-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 17, 2015 at 10:56:34AM +0000, Wang Nan wrote: SNIP > + obj->path); > + err = -EINVAL; > + goto errout; > + } > + ep = &obj->elf.ehdr; > + > + if ((ep->e_type != ET_REL) || (ep->e_machine != 0)) { > + pr_warning("%s is not an eBPF object file\n", > + obj->path); > + err = -EINVAL; > + goto errout; > + } > + > return 0; > +errout: > + bpf_obj_clear_elf(obj); > + return err; > +} > + > +struct bpf_object *bpf_open_object(const char *path) > +{ another suggestion for the namespace.. Arnaldo forces us ;-) to use the object name first plus '__(method name)' for interface functions so that would be: bpf_object__open bpf_object__close not sure we want to keep that standard in here though.. Arnaldo? jirka SNIP > +void bpf_close_object(struct bpf_object *obj) > +{ > + if (!obj) > + return; > + > + bpf_obj_clear_elf(obj); > + > + if (obj->path) > + free(obj->path); > + free(obj); > } > -- > 1.8.3.4 >