From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946346AbbEVRYO (ORCPT ); Fri, 22 May 2015 13:24:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42866 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161022AbbEVRYN (ORCPT ); Fri, 22 May 2015 13:24:13 -0400 Date: Fri, 22 May 2015 19:24:01 +0200 From: Jiri Olsa To: Wang Nan Cc: paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, jolsa@kernel.org, dsahern@gmail.com, ast@plumgrid.com, daniel@iogearbox.net, brendan.d.gregg@gmail.com, masami.hiramatsu.pt@hitachi.com, lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com Subject: Re: [RFC PATCH v3 20/37] bpf tools: Add bpf.c/h for common bpf operations Message-ID: <20150522172401.GF6609@krava.redhat.com> References: <1431860222-61636-1-git-send-email-wangnan0@huawei.com> <1431860222-61636-21-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431860222-61636-21-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 17, 2015 at 10:56:45AM +0000, Wang Nan wrote: SNIP > diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h > new file mode 100644 > index 0000000..1e9a53b > --- /dev/null > +++ b/tools/lib/bpf/bpf.h > @@ -0,0 +1,17 @@ > +/* > + * common eBPF ELF operations. > + * > + * Copyright (C) 2015, Wang Nan > + * Copyright (C) 2015, Huawei Inc. > + * > + * Released under the GPL v2. (and only v2, not any later version) > + */ > +#ifndef __LIBBPF_BPF_H > +#define __LIBBPF_BPF_H libbpf.h uses __BPF_LIBBPF_H ... you might want to come with some common pattern for these defines jirka