From: Minfei Huang <mhuang@redhat.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Minfei Huang <mnfhuang@gmail.com>, Jiri Kosina <jkosina@suse.cz>,
live-patching@vger.kernel.org, jpoimboe@redhat.com,
sjenning@redhat.com, vojtech@suse.cz,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] livepatch: introduce patch/func-walking helpers
Date: Sat, 23 May 2015 21:23:09 +0800 [thread overview]
Message-ID: <20150523132309.GA8636@dhcp-128-1.nay.redhat.com> (raw)
In-Reply-To: <555C33B6.3090600@suse.cz>
On 05/20/15 at 09:11am, Jiri Slaby wrote:
> On 05/20/2015, 03:51 AM, Minfei Huang wrote:
> > Sure. Sorry for confuse you with my comment.
>
> Oh, I see now, but:
>
> > list_for_each_entry(patch, &klp_patches, list) {
> > for (obj = patch->objs; obj->funcs; obj++) {
> > ----------------------------------
> > We get the fisrt object from the patch, then we break the loop. The code is more clearly to
> > use "if", instead of the loop.
> > ----------------------------------
> > if (!klp_is_module(obj) || strcmp(obj->name, mod->name))
> > continue;
>
> See 'continue' here. This *is* a loop and we do not fetch the first
> object. We look for the one with the same name.
>
> > if (action == MODULE_STATE_COMING) {
> > obj->mod = mod;
> > klp_module_notify_coming(patch, obj);
> > } else /* MODULE_STATE_GOING */
> > klp_module_notify_going(patch, obj);
> >
> > break;
> > ----------------------------------
> > Here we break the loop.
>
> Only if we found the one.
>
Hi, Jiri.
Ooops!
Since it is impossible for the differect objects which have the some
name in one patch, it is right to break the loop once we find a matched
object. It confuses me with the logic in __klp_enable_patch.
Thanks for your explanation.
Thanks
Minfei
next prev parent reply other threads:[~2015-05-23 13:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 10:01 [PATCH 1/2] livepatch: make kobject in klp_object statically allocated Jiri Slaby
2015-05-19 10:01 ` [PATCH 2/2] livepatch: introduce patch/func-walking helpers Jiri Slaby
2015-05-19 12:27 ` Minfei Huang
2015-05-19 21:58 ` Jiri Kosina
2015-05-20 1:51 ` Minfei Huang
2015-05-20 7:11 ` Jiri Slaby
2015-05-23 13:23 ` Minfei Huang [this message]
2015-05-19 14:22 ` Josh Poimboeuf
2015-05-19 21:59 ` Jiri Kosina
2015-05-19 14:21 ` [PATCH 1/2] livepatch: make kobject in klp_object statically allocated Josh Poimboeuf
2015-05-19 21:59 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150523132309.GA8636@dhcp-128-1.nay.redhat.com \
--to=mhuang@redhat.com \
--cc=jkosina@suse.cz \
--cc=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mnfhuang@gmail.com \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).