From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752463AbbEZJls (ORCPT ); Tue, 26 May 2015 05:41:48 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:52128 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752415AbbEZJlr (ORCPT ); Tue, 26 May 2015 05:41:47 -0400 Date: Tue, 26 May 2015 11:41:40 +0200 From: Sascha Hauer To: James Liao Cc: Matthias Brugger , Mike Turquette , Stephen Boyd , srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Kurtz , Ricky Liang , Rob Herring , linux-mediatek@lists.infradead.org, Henry Chen , Sascha Hauer , Yingjoe Chen , Eddie Huang , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/5] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS Message-ID: <20150526094140.GH6325@pengutronix.de> References: <1432192376-6712-1-git-send-email-jamesjj.liao@mediatek.com> <1432192376-6712-6-git-send-email-jamesjj.liao@mediatek.com> <20150526080516.GG6325@pengutronix.de> <1432631475.15597.29.camel@mtksdaap41> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432631475.15597.29.camel@mtksdaap41> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:38:29 up 70 days, 21:30, 108 users, load average: 0.05, 0.22, 0.31 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 26, 2015 at 05:11:15PM +0800, James Liao wrote: > Hi Sascha, > > On Tue, 2015-05-26 at 10:05 +0200, Sascha Hauer wrote: > > On Thu, May 21, 2015 at 03:12:56PM +0800, James Liao wrote: > > > +static void __init mtk_clk_register_apmixedsys_special(struct device_node *node, > > > + struct clk_onecell_data *clk_data) > > > +{ > > > + void __iomem *base; > > > + struct clk *clk; > > > + > > > + base = of_iomap(node, 0); > > > + if (!base) { > > > + pr_err("%s(): ioremap failed\n", __func__); > > > + return; > > > + } > > > + > > > + clk = mtk_clk_register_ref2usb_tx("ref2usb_tx", base + 0x8); > > > > The function seems to be for one special clock only. Why do you pass the > > name to it? They will never be called with another name, right? > > This function decides clock name and associates clock ID for special > clocks. In fact there may be another "special clocks" need to add into > apmixedsys. I think it's a better way to group clock names and clock IDs > in the same function for maintenance. How can a function with ref2usb_tx in its name ever register a clock with another name? Then it seems the function name is wrong. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |