From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752367AbbE0MJ3 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 May 2015 08:09:29 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:59131 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751211AbbE0MJ2 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 May 2015 08:09:28 -0400
Date: Wed, 27 May 2015 14:09:14 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Paul McKenney <paulmck@linux.vnet.ibm.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        John Stultz <john.stultz@linaro.org>,
        Joonwoo Park <joonwoop@codeaurora.org>,
        Wenbo Wang <wenbo.wang@memblaze.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Badhri Jagan Sridharan <Badhri@google.com>
Subject: Re: [patch 4/7] timer: Replace timer base by a cpu index
Message-ID: <20150527120914.GZ3644@twins.programming.kicks-ass.net>
References: <20150526210723.245729529@linutronix.de>
 <20150526224511.950084301@linutronix.de>
 <20150527092236.GC2256@linux>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150527092236.GC2256@linux>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 27, 2015 at 02:52:36PM +0530, Viresh Kumar wrote:
> > +		timer->flags = (timer->flags & ~TIMER_BASEMASK) | cpu;
> 
> Because 'cpu' is used only once in this routine, maybe we can use
> 'new_base->cpu' here and the line will still be exactly 80 columns
> long.
> 
> Not sure, but maybe we can create a inline helper for this operation
> as it is repeated at multiple places.

I suggested bitfields at some point I think. That gets the compiler to
generate those helpers for you.