From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752038AbbE0NDj (ORCPT ); Wed, 27 May 2015 09:03:39 -0400 Received: from mail.kernel.org ([198.145.29.136]:41584 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751307AbbE0NDi (ORCPT ); Wed, 27 May 2015 09:03:38 -0400 Date: Wed, 27 May 2015 10:03:34 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com, namhyung@kernel.org, jolsa@kernel.org, dsahern@gmail.com, daniel@iogearbox.net, brendan.d.gregg@gmail.com, masami.hiramatsu.pt@hitachi.com, lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com Subject: Re: [RFC PATCH v4 02/29] perf tools: Move linux/kernel.h to tools/include Message-ID: <20150527130334.GT17970@kernel.org> References: <1432704004-171454-1-git-send-email-wangnan0@huawei.com> <1432704004-171454-3-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432704004-171454-3-git-send-email-wangnan0@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, May 27, 2015 at 05:19:37AM +0000, Wang Nan escreveu: > This patch moves kernel.h from tools/perf/util/include/linux/kernel.h > to tools/include/linux/kernel.h to enable other libraries use macros in > it, like libbpf which will be introduced by further patches. > > Signed-off-by: Wang Nan > --- > tools/{perf/util => }/include/linux/kernel.h | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename tools/{perf/util => }/include/linux/kernel.h (100%) > > diff --git a/tools/perf/util/include/linux/kernel.h b/tools/include/linux/kernel.h > similarity index 100% > rename from tools/perf/util/include/linux/kernel.h > rename to tools/include/linux/kernel.h Thanks, applied and now testing it thoroughly with: $ make -C tools/perf build-test Please use the above command when doing things that touches a lot of stuff, as even in this seemingly simple case we may, for instance, end up using the kernel's kernel.h directly and miss something we may have on tools's (by now) kernel.h. Ah, using 'perf test', as root, from time to time, also is highly encouraged :-) Thanks, - Arnaldo