From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030195AbbE2QK6 (ORCPT ); Fri, 29 May 2015 12:10:58 -0400 Received: from mail.skyhub.de ([78.46.96.112]:40027 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751055AbbE2QKt (ORCPT ); Fri, 29 May 2015 12:10:49 -0400 Date: Fri, 29 May 2015 18:10:36 +0200 From: Borislav Petkov To: Andy Lutomirski Cc: Dave Hansen , Ingo Molnar , "linux-kernel@vger.kernel.org" , X86 ML , Thomas Gleixner , Dave Hansen , Oleg Nesterov , Rik van Riel , Suresh Siddha , Ingo Molnar , "H. Peter Anvin" , Fenghua Yu , Linus Torvalds , Peter Zijlstra Subject: Re: [PATCH 02/19] x86, fpu: Wrap get_xsave_addr() to make it safer Message-ID: <20150529161036.GK31435@pd.tnic> References: <20150527183609.964CC3BA@viggo.jf.intel.com> <20150527183610.56178C96@viggo.jf.intel.com> <20150528084140.GA31719@gmail.com> <556729FE.1020007@sr71.net> <20150528150114.GA10146@gmail.com> <55674157.4070108@sr71.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2015 at 06:05:33PM -0700, Andy Lutomirski wrote: > I would propose that we take the opposite approach and just ban > eagerfpu=off when MPX is enabled. We could then take the next step > and default eagerfpu=on for everyone and, if nothing breaks, then just > delete lazy mode entirely. > > I suspect we'd have to go back to Pentium 3 or earlier to find a CPU > on which lazy mode is actually a good idea. Last time I checked (and ran some benchmarks) it was only a minute slowdown so I say we kill lazy mode if it means significant code complexity drop. Can I also emulate Greg here and suggest that Pentium 3 people should buy newer hw? They should think about the environment, if nothing else. :-P -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --