From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758033AbbEaCKQ (ORCPT ); Sat, 30 May 2015 22:10:16 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39107 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754383AbbEaCKI (ORCPT ); Sat, 30 May 2015 22:10:08 -0400 Date: Sun, 31 May 2015 10:38:18 +0900 From: "gregkh@linuxfoundation.org" To: "Dhere, Chaitanya (C.)" Cc: "cristina.opriceana@gmail.com" , "hamohammed.sa@gmail.com" , "gdonald@gmail.com" , "mahfouz.saif.elyazal@gmail.com" , "benoit.taine@lip6.fr" , "paul.gortmaker@windriver.com" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] staging: rtl8192u: Patch to modify if, else conditions Message-ID: <20150531013818.GE28154@kroah.com> References: <20150519165543.GA2801@chaitanya-Ideapad-Z560> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150519165543.GA2801@chaitanya-Ideapad-Z560> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2015 at 04:55:57PM +0000, Dhere, Chaitanya (C.) wrote: > In this patch: > 1. the if condition is modified to remove > the unnecessary equality check. > 2. The else if condition is replaced by an else condition > since the variable checked in the if statement is a bool > making the else if unnecessary. > 3. Fixed indentation problem on line 1369. > These changes were detected with help of coccinelle tool. 3 different things means you need to send 3 different patches. Please only do one logical thing per patch. thanks, greg k-h