linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Pedro Marzo Perez <marzo.pedro@gmail.com>
Cc: navyasri.tech@gmail.com, dilekuzulmez@gmail.com, joe@perches.com,
	haticeerturk27@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3 v4] Staging: rtl8192u: Remove two useless lines at ieee80211_wep_null
Date: Sun, 31 May 2015 10:39:00 +0900	[thread overview]
Message-ID: <20150531013900.GF28154@kroah.com> (raw)
In-Reply-To: <1432167919-26298-3-git-send-email-marzo.pedro@gmail.com>

On Thu, May 21, 2015 at 02:25:18AM +0200, Pedro Marzo Perez wrote:
> Remove two lines at ieee80211_wep_null which checkpatch.pl reported as errors.
> The first one because it has a C99 comment style and the second one because it is a void
> return which is useless.
> 
> Signed-off-by: Pedro Marzo Perez <marzo.pedro@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> index bd789d1..94622cc 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> @@ -279,6 +279,4 @@ void __exit ieee80211_crypto_wep_exit(void)
>  
>  void ieee80211_wep_null(void)
>  {
> -//	printk("============>%s()\n", __func__);
> -	return;
>  }

Please just delete the function.

  reply	other threads:[~2015-05-31  2:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21  0:25 [PATCH 0/3 v4] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt_wep.c Pedro Marzo Perez
2015-05-21  0:25 ` [PATCH 1/3 v4] Staging: rtl8192u: Simplify error check code at prism2_wep_init Pedro Marzo Perez
2015-05-21  0:25 ` [PATCH 2/3 v4] Staging: rtl8192u: Remove two useless lines at ieee80211_wep_null Pedro Marzo Perez
2015-05-31  1:39   ` Greg KH [this message]
2015-06-01 22:19     ` pmarzo
2015-06-02  5:21       ` Greg KH
2015-06-02  8:08         ` pmarzo
2015-06-02  8:25           ` Greg KH
2015-06-02 13:35             ` pmarzo
2015-06-02 13:40               ` Greg KH
2015-06-03  7:20                 ` pmarzo
2015-05-21  0:25 ` [PATCH 3/3 v4] Staging: rtl8192u: Correct include indentation and openning braces at new line Pedro Marzo Perez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150531013900.GF28154@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=dilekuzulmez@gmail.com \
    --cc=haticeerturk27@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marzo.pedro@gmail.com \
    --cc=navyasri.tech@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).