From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757707AbbEaLT2 (ORCPT ); Sun, 31 May 2015 07:19:28 -0400 Received: from BERING.ISR.CS.CMU.EDU ([128.2.209.223]:35655 "EHLO bering.isr.cs.cmu.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751442AbbEaLTT (ORCPT ); Sun, 31 May 2015 07:19:19 -0400 Date: Sun, 31 May 2015 07:19:13 -0400 From: Jan Harkes To: Mikko Rapeli Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 96/98] HACK include/uapi/linux/coda_psdev.h: fix compilation in userspace Message-ID: <20150531111913.GA23377@cs.cmu.edu> Mail-Followup-To: Mikko Rapeli , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org References: <1433000370-19509-1-git-send-email-mikko.rapeli@iki.fi> <1433000370-19509-97-git-send-email-mikko.rapeli@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433000370-19509-97-git-send-email-mikko.rapeli@iki.fi> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 30, 2015 at 05:39:28PM +0200, Mikko Rapeli wrote: > Include linux/coda.h for caddr_t and use unsigned short type directly. > Userspace headers do not have list_head and wait_queue_head_t so just > ifdef them away which is a HACK. Any ideas how to fix this properly? I grepped the Coda userspace sources and it doesn't look like this particular struct is used there anyway, it is only used by the kernel module to track which requests are waiting to be read by the Coda userspace application and after that which requests are waiting for a response. I guess a proper fix would be to move this struct to a non-uapi header, or maybe even to the (probably) only C file in the kernel where it is used. Jan