From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753497AbbFAS6Z (ORCPT ); Mon, 1 Jun 2015 14:58:25 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:56230 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751474AbbFAS6Q (ORCPT ); Mon, 1 Jun 2015 14:58:16 -0400 Date: Mon, 1 Jun 2015 11:58:11 -0700 From: "Paul E. McKenney" To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, Steven Rostedt Subject: Re: [PATCH v2 0/9] rcu: Cleanup RCU tree initialization Message-ID: <20150601185811.GZ5989@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15060118-0033-0000-0000-000004B0367A Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 29, 2015 at 11:53:36AM +0200, Alexander Gordeev wrote: > Hello Paul, > > This is 2nd attempt to make RCU tree initialization bit more > clear and optimize memory footprint of data associated with > the tree. Thank you for sending these -- please see the comment on patch #1. I have queued these for testing in the meantime, but please either explain why I am wrong or resend the set with the fix. Thanx, Paul > Changes since v1: > - patch 3 fixed to accomodate nr_cpus=1, otherwise rcu_num_lvls > would yield zero, which is wrong; > > The series is against "linux-rcu" tree "rcu/dev" branch > > Thanks! > > Cc: "Paul E. McKenney" > Cc: Steven Rostedt > > Alexander Gordeev (9): > rcu: Panic if RCU tree can not accommodate all CPUs > rcu: Remove superfluous local variable in rcu_init_geometry() > rcu: Cleanup rcu_init_geometry() code and arithmetics > rcu: Simplify rcu_init_geometry() capacity arithmetics > rcu: Limit rcu_state::levelcnt[] to RCU_NUM_LVLS items > rcu: Limit rcu_capacity[] size to RCU_NUM_LVLS items > rcu: Remove unnecessary fields from rcu_state structure > rcu: Limit count of static data to the number of RCU levels > rcu: Simplify arithmetic to calculate number of RCU nodes > > kernel/rcu/tree.c | 99 +++++++++++++++++++++--------------------------- > kernel/rcu/tree.h | 33 ++++++++-------- > kernel/rcu/tree_plugin.h | 4 +- > 3 files changed, 61 insertions(+), 75 deletions(-) > > -- > 1.8.3.1 >