From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754628AbbFBBPY (ORCPT ); Mon, 1 Jun 2015 21:15:24 -0400 Received: from mail.kernel.org ([198.145.29.136]:51289 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754425AbbFBBPR (ORCPT ); Mon, 1 Jun 2015 21:15:17 -0400 Date: Mon, 1 Jun 2015 22:15:10 -0300 From: Arnaldo Carvalho de Melo To: Alexei Starovoitov Cc: Wang Nan , namhyung@kernel.org, masami.hiramatsu.pt@hitachi.com, paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com, jolsa@kernel.org, dsahern@gmail.com, daniel@iogearbox.net, brendan.d.gregg@gmail.com, lizefan@huawei.com, hekuang@huawei.com, xiakaixu@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com Subject: Re: [RFC PATCH v5 00/30] perf tools: filtering events using eBPF programs Message-ID: <20150602011510.GL624@kernel.org> References: <1433144296-74992-1-git-send-email-wangnan0@huawei.com> <20150602004836.GA1700@Alexeis-MacBook-Pro.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150602004836.GA1700@Alexeis-MacBook-Pro.local> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Jun 01, 2015 at 05:48:38PM -0700, Alexei Starovoitov escreveu: > On Mon, Jun 01, 2015 at 07:37:46AM +0000, Wang Nan wrote: > > This is the 5th version of patch series which tries to introduce eBPF > > programs to perf. It enables 'perf record' to filter events using eBPF > > thanks! As far as I could review this set addresses all of my earlier comments. > > > Patch 4/30 - 22/30 introduce libbpf, which first parse eBPF object > > files then load maps and programs into kernel. > > the libbpf side looks good. > For the patches that I haven't explictly acked yet: > Acked-by: Alexei Starovoitov > > > Patch 23-30 - 30/30 are perf side modifications, introducing > > new syntax: '--event [.*].(o|bpf)' to enable passing eBPF object > > files to 'perf record', create probing points and attach programs > > to those points. > > Looks good to me as well. > Arnaldo, please take a deep look :) I'll try applying and testing it, from looking at the description of the changes it looks as well that my concerns have been addressed, Thanks! - Arnaldo