From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932199AbbFBBbZ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 1 Jun 2015 21:31:25 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:51839 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754669AbbFBBbS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 1 Jun 2015 21:31:18 -0400
Date: Tue, 2 Jun 2015 10:31:15 +0900
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: David Decotigny <ddecotig@gmail.com>
Cc: devel@driverdev.osuosl.org, HPDD-discuss@ml01.01.org,
        Andreas Dilger <andreas.dilger@intel.com>,
        Liang Zhen <liang.zhen@intel.com>, Peng Tao <bergwolf@gmail.com>,
        Doug Oucharek <doug.s.oucharek@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Oleg Drokin <oleg.drokin@intel.com>,
        Amir Shehata <amir.shehata@intel.com>,
        Isaac Huang <he.huang@intel.com>
Subject: Re: [PATCH v1] staging: lustre: libcfs: add __user annotation in
 libcfs_ioctl_data
Message-ID: <20150602013115.GB23940@kroah.com>
References: <1432615204-4062-1-git-send-email-ddecotig@gmail.com>
 <20150531022744.GA31012@kroah.com>
 <CAG88wWYSZvS+NByVH3APY-nyF+Di6q_EJPMMXZg9yY4f8rVGHw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAG88wWYSZvS+NByVH3APY-nyF+Di6q_EJPMMXZg9yY4f8rVGHw@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 01, 2015 at 12:21:30PM -0700, David Decotigny wrote:
> Thanks for reviewing.
> 
> The 2 struct members were not marked as __user, which this patch does
> here. This was causing warnings with copy from/to user (see commit
> description). This patch also propagates the annotation to the couple
> of functions that are using those members.

Lustre's structures are a total mess of kernel and user pointers and
trying to properly mark them as which they are supposed to be at what
point in time is a very difficult task.  People keep trying and get it
wrong, so I suggest just leaving this alone until the developers unwind
the structure mess as that will be necessary for this code to get merged
into the main part of the kernel.

sorry,

greg k-h