From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754394AbbFBFNZ (ORCPT ); Tue, 2 Jun 2015 01:13:25 -0400 Received: from mail-am1on0117.outbound.protection.outlook.com ([157.56.112.117]:31232 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752806AbbFBFNS convert rfc822-to-8bit (ORCPT ); Tue, 2 Jun 2015 01:13:18 -0400 From: "Dhere, Chaitanya (C.)" To: "sudipm.mukherjee@gmail.com" CC: "cristina.opriceana@gmail.com" , "hamohammed.sa@gmail.com" , "gdonald@gmail.com" , "mahfouz.saif.elyazal@gmail.com" , "benoit.taine@lip6.fr" , "paul.gortmaker@windriver.com" , "gregkh@linuxfoundation.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] staging: rtl8192u: Patch to modify if, else conditions Thread-Topic: [PATCH] staging: rtl8192u: Patch to modify if, else conditions Thread-Index: AQHQklStq0r7sW8mVUOXJrLUlFImJp2VYEYAgANgtIA= Date: Tue, 2 Jun 2015 05:13:15 +0000 Message-ID: <20150602051311.GA17953@ubuntu> In-Reply-To: <20150531013818.GE28154@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=cvijaydh@visteon.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [74.112.164.116] x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM3PR06MB1394;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM3PR06MB194; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:AM3PR06MB1394;BCL:0;PCL:0;RULEID:;SRVR:AM3PR06MB1394; x-forefront-prvs: 05954A7C45 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(189002)(51704005)(199003)(164054003)(40100003)(122556002)(92566002)(101416001)(2501003)(189998001)(33716001)(77156002)(62966003)(68736005)(102836002)(2860100001)(2900100001)(2950100001)(66066001)(64706001)(5001960100002)(54356999)(50986999)(110136002)(106356001)(19580405001)(19580395003)(105586002)(5001830100001)(106116001)(5001860100001)(2351001)(4001540100001)(81156007)(97736004)(87936001)(2656002)(46102003)(5002640100001)(33656002)(86362001);DIR:OUT;SFP:1102;SCL:1;SRVR:AM3PR06MB1394;H:AM3PR06MB1393.eurprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-ID: <402F83748DDF134C8B6ACDE38C95D8D9@eurprd06.prod.outlook.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2015 05:13:15.2012 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a147aaf-01ec-498c-80a1-e34a8c63c548 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR06MB1394 X-OriginatorOrg: visteon.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 31, 2015 at 10:38:18AM +0900, gregkh@linuxfoundation.org wrote: > On Tue, May 19, 2015 at 04:55:57PM +0000, Dhere, Chaitanya (C.) wrote: > > In this patch: > > 1. the if condition is modified to remove > > the unnecessary equality check. > > 2. The else if condition is replaced by an else condition > > since the variable checked in the if statement is a bool > > making the else if unnecessary. > > 3. Fixed indentation problem on line 1369. > > These changes were detected with help of coccinelle tool. > > 3 different things means you need to send 3 different patches. Please > only do one logical thing per patch. > > thanks, > > greg k-h Hello, I will make the correction in subject and resend the patch Thanks, chaitanya