From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755570AbbFBGsV (ORCPT ); Tue, 2 Jun 2015 02:48:21 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:34622 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751847AbbFBGsN (ORCPT ); Tue, 2 Jun 2015 02:48:13 -0400 Date: Tue, 2 Jun 2015 12:18:06 +0530 From: Sudip Mukherjee To: Isaac Assegai Cc: gregkh@linuxfoundation.org, teddy.wang@siliconmotion.com, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/12] Staging: sm750fb: Insert spaces after commas in three files. Message-ID: <20150602064806.GF6382@sudip-PC> References: <1433134873-9869-1-git-send-email-isaac.a.travers@gmail.com> <1433134873-9869-13-git-send-email-isaac.a.travers@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433134873-9869-13-git-send-email-isaac.a.travers@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 31, 2015 at 10:01:13PM -0700, Isaac Assegai wrote: > Insert Spaces after commas to rectify the following checkpatch > errors in ddk750_mode.c, sm750_accel.c and sm750_help.h: > ERROR: space required after that ',' > > Signed-off-by: Isaac Assegai > --- > drivers/staging/sm750fb/ddk750_mode.c | 46 +++++++++++++++++------------------ > drivers/staging/sm750fb/sm750_accel.c | 2 +- > drivers/staging/sm750fb/sm750_help.h | 2 +- > 3 files changed, 25 insertions(+), 25 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c > index 4e252fb..a054747 100644 > --- a/drivers/staging/sm750fb/ddk750_mode.c > +++ b/drivers/staging/sm750fb/ddk750_mode.c > @@ -101,29 +101,29 @@ static int programModeRegisters(mode_parameter_t * pModeParam, pll_value_t * pll > | FIELD_VALUE(0, CRT_VERTICAL_SYNC, START, pModeParam->vertical_sync_start - 1)); > > > - ulTmpValue = FIELD_VALUE(0, CRT_DISPLAY_CTRL,VSYNC_PHASE, pModeParam->vertical_sync_polarity)| > + ulTmpValue = FIELD_VALUE(0, CRT_DISPLAY_CTRL, VSYNC_PHASE, pModeParam->vertical_sync_polarity)| > FIELD_VALUE(0, CRT_DISPLAY_CTRL, HSYNC_PHASE, pModeParam->horizontal_sync_polarity)| > - FIELD_SET(0, CRT_DISPLAY_CTRL, TIMING,ENABLE)| > - FIELD_SET(0,CRT_DISPLAY_CTRL,PLANE,ENABLE); > + FIELD_SET(0, CRT_DISPLAY_CTRL, TIMING, ENABLE)| > + FIELD_SET(0, CRT_DISPLAY_CTRL, PLANE, ENABLE); I am getting confused now. This part you have modified in patch 10/12 and i just replied that you have missed two modifications. regards sudip