From: Ingo Molnar <mingo@kernel.org>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: Balbir Singh <bsingharora@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
srikar@linux.vnet.ibm.com
Subject: Re: [PATCH] proc/schedstat: Expose /proc/<pid>/schedstat if delay accounting is enabled
Date: Tue, 2 Jun 2015 09:58:25 +0200 [thread overview]
Message-ID: <20150602075825.GA12057@gmail.com> (raw)
In-Reply-To: <20150529170600.GF17421@naverao1-tp.ibm.com>
* Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> wrote:
> On 2015/05/29 11:54AM, Ingo Molnar wrote:
> >
> > > > So all this should really be cleaned up:
> > > >
> > > > include/linux/sched.h:#if defined(CONFIG_SCHEDSTATS) || defined(CONFIG_TASK_DELAY_ACCT)
> > > > include/linux/sched.h:#endif /* defined(CONFIG_SCHEDSTATS) || defined(CONFIG_TASK_DELAY_ACCT) */
> > > > include/linux/sched.h:#if defined(CONFIG_SCHEDSTATS) || defined(CONFIG_TASK_DELAY_ACCT)
> > > > kernel/sched/core.c:#if defined(CONFIG_SCHEDSTATS) || defined(CONFIG_TASK_DELAY_ACCT)
> > > > kernel/sched/stats.h:#if defined(CONFIG_SCHEDSTATS) || defined(CONFIG_TASK_DELAY_ACCT)
> > > > kernel/sched/stats.h:#endif /* CONFIG_SCHEDSTATS || CONFIG_TASK_DELAY_ACCT */
> > > >
> > > > by introducing an intermediate Kconfig variable, named CONFIG_SCHED_INFO or so,
> > > > and selected by both SCHEDSTATS and TASK_DELAY_ACCT.
> > > >
> > > > Please make it two patches: the first one adds CONFIG_SCHED_INFO and cleans up the
> > > > code to use it, the second one uses it for the procps change.
> > >
> > > Sure, will do.
> > >
> > > On a related note, even though sum_exec_runtime is available unconditionally, I
> > > dump all zeroes in my patch if !sched_info_on() to make it clear that some of
> > > the fields are not available. Is this ok or should be display sum_exec_runtime
> > > regardless of sched_info?
> >
> > So I'd suggest printing -1 for non-available fields, that should be unambigous
> > enough and makes it also possible to write out 0 in some cases.
>
> Per Documentation/scheduler/sched-stats.txt (and the linked latency.c there),
> user-space seems to be expecting unsigned values here. Would displaying -1 here
> be ok?
Probably not (the code is silly, why doesn't it split up the string and use
atol()?) - hopefully real user-space is better? Can you try some real, packaged up
tools that read schedstats, to see whether they work with -1?
Thanks,
Ingo
next prev parent reply other threads:[~2015-06-02 7:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 7:12 [PATCH] proc/schedstat: Expose /proc/<pid>/schedstat if delay accounting is enabled Naveen N. Rao
2015-05-28 5:11 ` Naveen N. Rao
2015-05-28 9:11 ` Balbir Singh
2015-05-29 6:16 ` Naveen N. Rao
2015-05-29 8:04 ` Ingo Molnar
2015-05-29 8:55 ` Naveen N. Rao
2015-05-29 9:18 ` Ingo Molnar
2015-05-29 9:45 ` Naveen N. Rao
2015-05-29 9:54 ` Ingo Molnar
2015-05-29 17:06 ` Naveen N. Rao
2015-06-02 7:58 ` Ingo Molnar [this message]
2015-06-25 8:39 ` Naveen N. Rao
2015-06-25 12:12 ` Ingo Molnar
2015-06-25 18:00 ` Cong Wang
2015-06-25 18:27 ` Naveen N. Rao
2015-06-25 18:40 ` Cong Wang
2015-06-26 8:39 ` Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602075825.GA12057@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=bsingharora@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).