From: Isaac Assegai <isaac.a.travers@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: gregkh@linuxfoundation.org, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/12] Staging: sm750fb: Insert spaces after commas in three files.
Date: Tue, 2 Jun 2015 01:30:54 -0700 [thread overview]
Message-ID: <20150602083054.GA11353@ubuntu-desktop> (raw)
In-Reply-To: <20150602082555.GA4436@sudip-PC>
On Tue, Jun 02, 2015 at 01:55:56PM +0530, Sudip Mukherjee wrote:
> On Tue, Jun 02, 2015 at 12:55:22AM -0700, Isaac Assegai wrote:
> > On Tue, Jun 02, 2015 at 12:18:06PM +0530, Sudip Mukherjee wrote:
> > > On Sun, May 31, 2015 at 10:01:13PM -0700, Isaac Assegai wrote:
> <snip>
> > > > + FIELD_SET(0, CRT_DISPLAY_CTRL, TIMING, ENABLE)|
> > > > + FIELD_SET(0, CRT_DISPLAY_CTRL, PLANE, ENABLE);
> > > I am getting confused now.
> > > This part you have modified in patch 10/12 and i just replied that
> > > you have missed two modifications.
> > >
> > Thanks for your feedback Sudip, I have a few questions:
> > 1. After applying the first 11 patches I ran checkpatch again and noticed that
> > I missed three warnings so I ran a 12th patch fixing them. That's why you
> > see the 12th patch modifying a file that another patch already touched.
> > What should be done in this type of situation?
> you have to start from the beginning again. :(
> I have faced such similar situation also, but starting for the beginnig
> is the only way.
> >
> > 2. On Patch 3 you pointed out two trailing whitespace errors.
> > I ran checkpatch on all the patches before I sent them to
> > make sure I didn't introduce any new errors,
> but it looks like they were introduced in your patch.
> > - int (*de_imageblit)(struct lynx_accel *,const char *,u32,u32,u32,
> > - u32,u32,u32,u32,u32,u32,u32,u32,u32);
> > + int (*de_imageblit)(struct lynx_accel *, const char *, u32, u32, u32, u32,
> the original code was having three u32, i think when you moved one more
> u32 from the following line you forgot to remove the space after that.
>
> >however
> > there are *many* warnings and errors showing up from
> > the poor styling already present and I missed these
> > whitespace errors in the mess.
> > Can I make checkpatch suppress any errors that might have already
> > been present in the code and only show me those issues introduced
> > by the patch itself? If not, how did you identify it?
> i dont think checkpatch can work like that way.
> identification was easy. i saw checkpatch giving error and noticed you
> have modified the code. So i checked the original code if trailing
> whitespace was there or not.
>
> regards
> sudip
Okay,
I'll re-run this and send a new version in the morning.
Thanks,
Isaac
prev parent reply other threads:[~2015-06-02 8:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1433134873-9869-1-git-send-email-isaac.a.travers@gmail.com>
[not found] ` <1433134873-9869-3-git-send-email-isaac.a.travers@gmail.com>
2015-06-02 6:15 ` [PATCH 02/12] Staging: sm750fb: sm750_help.h: Insert spaces after commas Sudip Mukherjee
[not found] ` <1433134873-9869-4-git-send-email-isaac.a.travers@gmail.com>
2015-06-02 6:25 ` [PATCH 03/12] Staging: sm750fb: sm750.h: " Sudip Mukherjee
[not found] ` <1433134873-9869-11-git-send-email-isaac.a.travers@gmail.com>
2015-06-02 6:41 ` [PATCH 10/12] Staging: sm750fb: Insert spaces after commas in two files Sudip Mukherjee
[not found] ` <1433134873-9869-13-git-send-email-isaac.a.travers@gmail.com>
2015-06-02 6:48 ` [PATCH 12/12] Staging: sm750fb: Insert spaces after commas in three files Sudip Mukherjee
2015-06-02 7:55 ` Isaac Assegai
2015-06-02 8:25 ` Sudip Mukherjee
2015-06-02 8:30 ` Isaac Assegai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602083054.GA11353@ubuntu-desktop \
--to=isaac.a.travers@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).