From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Konrad Zapalowicz <bergo.torino@gmail.com>
Cc: Johnny Kim <johnny.kim@atmel.com>,
Rachel Kim <rachel.kim@atmel.com>, Dean Lee <dean.lee@atmel.com>,
Chris Park <chris.park@atmel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wilc1000: fix warning while printing
Date: Tue, 2 Jun 2015 14:31:47 +0530 [thread overview]
Message-ID: <20150602090127.GA5576@sudip-PC> (raw)
In-Reply-To: <20150602085840.GC5903@patagonia>
On Tue, Jun 02, 2015 at 10:58:40AM +0200, Konrad Zapalowicz wrote:
> On 06/02, Sudip Mukherjee wrote:
> > On Tue, Jun 02, 2015 at 10:29:17AM +0200, Konrad Zapalowicz wrote:
> > > On 06/02, Sudip Mukherjee wrote:
> > > > size_t should print using %zu, but here it was using %d and hence we
> > > > were getting warning while printing.
> > > >
> > > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > > > ---
> > > >
> > > > I think it will be easy to remove the other warnings if all the typedefs
> > > > are removed first.
> > > >
> > > > drivers/staging/wilc1000/wilc_spi.c | 2 +-
> > > > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
> > > > 2 files changed, 4 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c
> > > > index d0e7610..6d854fd 100644
> > > > --- a/drivers/staging/wilc1000/wilc_spi.c
> > > > +++ b/drivers/staging/wilc1000/wilc_spi.c
> > > > @@ -404,7 +404,7 @@ static int spi_cmd_complete(uint8_t cmd, uint32_t adr, uint8_t *b, uint32_t sz,
> > > > #undef NUM_DUMMY_BYTES
> > > >
> > > > if (len2 > (sizeof(wb) / sizeof(wb[0]))) {
> > > > - PRINT_ER("[wilc spi]: spi buffer size too small (%d) (%d)\n",
> > > > + PRINT_ER("[wilc spi]: spi buffer size too small (%d) (%lu)\n",
> > >
> > > Hi, it seems that the above line should use %zu too. Am I correct or I'm
> > > missing something?
> > oops. my mistake. %lu is correct but i missed mentioning the warning
> > about long unsigned int in the commit message.
>
> Why %lu here and %zu in other places? I mean that it is the same size_t
> or I'm missing something?
no, this is unsigned long int.
The warning here was:
drivers/staging/wilc1000/wilc_spi.c:407:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘long unsigned int’ [-Wformat]
so size_t used %zu and unsigned long int should use %lu
regards
sudip
>
> - konrad
>
> > regards
> > sudip
prev parent reply other threads:[~2015-06-02 9:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 7:56 [PATCH] staging: wilc1000: fix warning while printing Sudip Mukherjee
2015-06-02 8:29 ` Konrad Zapalowicz
2015-06-02 8:35 ` Sudip Mukherjee
2015-06-02 8:58 ` Konrad Zapalowicz
2015-06-02 9:01 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602090127.GA5576@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=bergo.torino@gmail.com \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).