From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: umgwanakikbuti@gmail.com, mingo@elte.hu, ktkhai@parallels.com,
rostedt@goodmis.org, juri.lelli@gmail.com,
pang.xunlei@linaro.org, oleg@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 1/7] sched: Replace post_schedule with a balance callback list
Date: Wed, 3 Jun 2015 10:11:59 +0530 [thread overview]
Message-ID: <20150603044157.GA1545@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150601140839.630055365@infradead.org>
* Peter Zijlstra <peterz@infradead.org> [2015-06-01 15:58:19]:
[...]
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -213,9 +213,16 @@ static inline bool need_pull_dl_task(str
> return dl_task(prev);
> }
>
> -static inline void set_post_schedule(struct rq *rq)
> +static DEFINE_PER_CPU(struct callback_head, dl_balance_head);
> +
> +static void push_dl_tasks(struct rq *);
> +
> +static inline void queue_push_tasks(struct rq *rq)
> {
> - rq->post_schedule = has_pushable_dl_tasks(rq);
> + if (!has_pushable_dl_tasks(rq))
> + return;
> +
> + queue_balance_callback(rq, &per_cpu(dl_balance_head, rq->cpu), push_dl_tasks);
> }
When compiling with CONFIG_SMP=n, following build warning is triggered:
CC kernel/sched/deadline.o
kernel/sched/deadline.c: In function âpick_next_task_dlâ:
kernel/sched/deadline.c:1136:2: error: implicit declaration of function âqueue_push_tasksâ [-Werror=implicit-function-declaration]
queue_push_tasks(rq);
^
cc1: some warnings being treated as errors
set_post_schedule() exist for CONFIG_SMP=n case, which was not modified to
queue_push_tasks().
[...]
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -624,9 +624,10 @@ struct rq {
> unsigned long cpu_capacity;
> unsigned long cpu_capacity_orig;
>
> + struct callback_head *balance_callback;
> +
> unsigned char idle_balance;
> /* For active balancing */
> - int post_schedule;
> int active_balance;
> int push_cpu;
> struct cpu_stop_work active_balance_work;
> @@ -695,6 +696,21 @@ struct rq {
> #endif
> };
>
> +static inline void
> +queue_balance_callback(struct rq *rq,
> + struct callback_head *head,
> + void (*func)(struct rq *rq))
> +{
> + lockdep_assert_held(&rq->lock);
> +
> + if (unlikely(head->next))
> + return;
> +
> + head->func = (void (*)(struct callback_head *))func;
> + head->next = rq->balance_callback;
> + rq->balance_callback = head;
> +}
> +
While compiling with CONFIG_SMP=n, another build error is seen:
In file included from kernel/sched/core.c:86:0:
kernel/sched/sched.h: In function âqueue_balance_callbackâ:
kernel/sched/sched.h:710:17: error: âstruct rqâ has no member named âbalance_callbackâ
head->next = rq->balance_callback;
^
kernel/sched/sched.h:711:4: error: âstruct rqâ has no member named âbalance_callbackâ
rq->balance_callback = head;
^
Guarding queue_balance_callback() with #ifdef CONFIG_SMP fixes
the issue, as all of the call sites are also with #ifdef CONFIG_SMP
Thanks,
Kamalesh
next prev parent reply other threads:[~2015-06-03 4:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 13:58 [RFC][PATCH 0/7] sched: balance callbacks Peter Zijlstra
2015-06-01 13:58 ` [RFC][PATCH 1/7] sched: Replace post_schedule with a balance callback list Peter Zijlstra
2015-06-03 4:41 ` Kamalesh Babulal [this message]
2015-06-03 7:21 ` Peter Zijlstra
2015-06-03 8:24 ` pang.xunlei
2015-06-03 8:55 ` Peter Zijlstra
2015-06-05 7:13 ` pang.xunlei
2015-06-05 7:19 ` Peter Zijlstra
2015-06-01 13:58 ` [RFC][PATCH 2/7] sched: Use replace normalize_task() with __sched_setscheduler() Peter Zijlstra
2015-06-01 13:58 ` [RFC][PATCH 3/7] sched: Allow balance callbacks for check_class_changed() Peter Zijlstra
2015-06-02 13:58 ` Kirill Tkhai
2015-06-02 14:27 ` Peter Zijlstra
2015-06-02 16:07 ` Peter Zijlstra
2015-06-02 16:27 ` Kirill Tkhai
2015-06-03 7:32 ` Peter Zijlstra
2015-06-03 10:40 ` Kirill Tkhai
2015-06-03 10:42 ` Kirill Tkhai
2015-06-03 10:45 ` Peter Zijlstra
2015-06-01 13:58 ` [RFC][PATCH 4/7] sched,rt: Remove return value from pull_rt_task() Peter Zijlstra
2015-06-01 13:58 ` [RFC][PATCH 5/7] sched,rt: Convert switched_{from,to}_rt() / prio_changed_rt() to balance callbacks Peter Zijlstra
2015-06-01 13:58 ` [RFC][PATCH 6/7] sched,dl: Remove return value from pull_dl_task() Peter Zijlstra
2015-06-01 13:58 ` [RFC][PATCH 7/7] sched,dl: Convert switched_{from,to}_dl() / prio_changed_dl() to balance callbacks Peter Zijlstra
2015-06-03 4:52 ` Kamalesh Babulal
2015-06-01 14:16 ` [RFC][PATCH 0/7] sched: " Peter Zijlstra
2015-06-01 14:42 ` Mike Galbraith
2015-06-02 6:48 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150603044157.GA1545@linux.vnet.ibm.com \
--to=kamalesh@linux.vnet.ibm.com \
--cc=juri.lelli@gmail.com \
--cc=ktkhai@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=pang.xunlei@linaro.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).