From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: James Simmons <jsimmons@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
lustre-devel@lists.lustre.org
Subject: Re: [PATCH v4 6/7] staging:lustre: style cleanups for lib-socket.c
Date: Thu, 4 Jun 2015 11:32:47 +0530 [thread overview]
Message-ID: <20150604060247.GD6376@sudip-PC> (raw)
In-Reply-To: <1433361433-24976-7-git-send-email-jsimmons@infradead.org>
On Wed, Jun 03, 2015 at 03:57:12PM -0400, James Simmons wrote:
> Handle all the style issues reported by checkpatch.pl.
> Remove general white spaces, spaces in function calls,
> etc.
>
> Signed-off-by: James Simmons <jsimmons@infradead.org>
> ---
<snip>
> @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp)
> if (nalloc * sizeof(*ifr) > PAGE_CACHE_SIZE) {
> toobig = 1;
> nalloc = PAGE_CACHE_SIZE/sizeof(*ifr);
> - CWARN("Too many interfaces: only enumerating first %d\n",
> - nalloc);
> + CWARN("Too many interfaces: only enumerating "
> + "first %d\n", nalloc);
oops. Joe told you not to break the user visible strings.
The CodingStyle says: "However, never break user-visible strings such as
printk messages, because that breaks the ability to grep for them."
regards
sudip
next prev parent reply other threads:[~2015-06-04 6:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 19:57 [PATCH v4 0/7] staging:lustre: remove tcpip abstraction from libcfs James Simmons
2015-06-03 19:57 ` [PATCH v4 1/7] staging:lustre: move tcpip abstraction James Simmons
2015-06-04 5:35 ` Sudip Mukherjee
2015-06-04 7:34 ` Dan Carpenter
2015-06-04 7:45 ` Sudip Mukherjee
2015-06-09 13:38 ` [lustre-devel] " Simmons, James A.
2015-06-08 19:33 ` Greg Kroah-Hartman
2015-06-08 19:57 ` Joe Perches
2015-06-03 19:57 ` [PATCH v4 2/7] staging:lustre: remove useless libcfs_sock_release James Simmons
2015-06-03 19:57 ` [PATCH v4 3/7] staging:lustre: remove useless libcfs_sock_abort_accept James Simmons
2015-06-03 19:57 ` [PATCH v4 4/7] staging:lustre: rename tcpip handling functions to lnet_* prefix James Simmons
2015-06-04 5:57 ` Sudip Mukherjee
2015-06-04 7:41 ` Dan Carpenter
2015-06-03 19:57 ` [PATCH v4 5/7] staging:lustre: use available kernel wrappers in lib-socket.c James Simmons
2015-06-03 19:57 ` [PATCH v4 6/7] staging:lustre: style cleanups for lib-socket.c James Simmons
2015-06-04 6:02 ` Sudip Mukherjee [this message]
2015-06-04 7:54 ` Dan Carpenter
2015-06-03 19:57 ` [PATCH v4 7/7] staging:lustre: Update license and copyright " James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150604060247.GD6376@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).