From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754579AbbFEQT3 (ORCPT ); Fri, 5 Jun 2015 12:19:29 -0400 Received: from mga11.intel.com ([192.55.52.93]:3893 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752139AbbFEQT1 (ORCPT ); Fri, 5 Jun 2015 12:19:27 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,559,1427785200"; d="scan'208";a="737792939" Date: Fri, 5 Jun 2015 09:19:26 -0700 From: Andi Kleen To: Jiri Olsa Cc: Sukadev Bhattiprolu , mingo@redhat.com, Michael Ellerman , Arnaldo Carvalho de Melo , namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v14 15/19] perf, tools: Support long descriptions with perf list Message-ID: <20150605161926.GU1187@tassilo.jf.intel.com> References: <1433485647-9314-1-git-send-email-sukadev@linux.vnet.ibm.com> <1433485647-9314-16-git-send-email-sukadev@linux.vnet.ibm.com> <20150605102138.GB29934@krava.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150605102138.GB29934@krava.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 05, 2015 at 12:21:38PM +0200, Jiri Olsa wrote: > On Thu, Jun 04, 2015 at 11:27:23PM -0700, Sukadev Bhattiprolu wrote: > > SNIP > > > --- > > tools/perf/builtin-list.c | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c > > index 3f058f7..d0f7a18 100644 > > --- a/tools/perf/builtin-list.c > > +++ b/tools/perf/builtin-list.c > > @@ -22,10 +22,13 @@ int cmd_list(int argc, const char **argv, const char *prefix __maybe_unused) > > { > > int i; > > bool raw_dump = false; > > + bool long_desc_flag = false; > > struct option list_options[] = { > > OPT_BOOLEAN(0, "raw-dump", &raw_dump, "Dump raw events"), > > OPT_BOOLEAN('d', "desc", &desc_flag, > > "Print extra event descriptions. --no-desc to not print."), > > + OPT_BOOLEAN('d', "long-desc", &long_desc_flag, > > + "Print longer event descriptions."), > > hum, it should be 'v' , right? Yes that's right. Also BTW need to add the new option to the usage line a few lines below. -Andi -- ak@linux.intel.com -- Speaking for myself only