From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932171AbbFHPTr (ORCPT <rfc822;w@1wt.eu>);
	Mon, 8 Jun 2015 11:19:47 -0400
Received: from mail-wi0-f170.google.com ([209.85.212.170]:36945 "EHLO
	mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752728AbbFHPTj (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 8 Jun 2015 11:19:39 -0400
From: Grant Likely <grant.likely@linaro.org>
Subject: Re: [PATCH v2] drivers: of/base: move of_init to driver_init
To: Rob Herring <robherring2@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>
In-Reply-To: <CAL_JsqKEcpWiPsORFrQs+dhqM4qcgMPyaz0ijVEMNkFeVQfkWQ@mail.gmail.com>
References: <1431595695-17103-1-git-send-email-sudeep.holla@arm.com>
	<1431613704-30801-1-git-send-email-sudeep.holla@arm.com>
	<555B2C9C.1000709@arm.com> <20150519171732.GD9213@kroah.com>
	<20150607070539.A8C7EC409D1@trevor.secretlab.ca>
	<CAL_JsqKEcpWiPsORFrQs+dhqM4qcgMPyaz0ijVEMNkFeVQfkWQ@mail.gmail.com>
Date: Mon, 08 Jun 2015 16:19:35 +0100
Message-Id: <20150608151935.2783CC407C6@trevor.secretlab.ca>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 7 Jun 2015 19:29:17 -0500
, Rob Herring <robherring2@gmail.com>
 wrote:
> On Sun, Jun 7, 2015 at 2:05 AM, Grant Likely <grant.likely@linaro.org> wrote:
> > On Tue, 19 May 2015 10:17:32 -0700
> > , Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >  wrote:
> >> On Tue, May 19, 2015 at 01:29:16PM +0100, Sudeep Holla wrote:
> >> > Hi Rob/Greg,
> >> >
> >> > On 14/05/15 15:28, Sudeep Holla wrote:
> >> > >Commit 5590f3196b29 ("drivers/core/of: Add symlink to device-tree from
> >> > >devices with an OF node") adds the symlink `of_node` for each device
> >> > >pointing to it's device tree node while creating/initialising it.
> >> > >
> >> > >However the devicetree sysfs is created and setup in of_init which is
> >> > >executed at core_initcall level. For all the devices created before
> >> > >of_init, the following error is thrown:
> >> > >   "Error -2(-ENOENT) creating of_node link"
> >> > >
> >> > >Like many other components in driver model, initialize the sysfs support
> >> > >for OF/devicetree from driver_init so that it's ready before any devices
> >> > >are created.
> >> > >
> >> > >Fixes: 5590f3196b29 ("drivers/core/of: Add symlink to device-tree from
> >> > >   devices with an OF node")
> >> > >Suggested-by: Rob Herring <robh+dt@kernel.org>
> >> > >Cc: Grant Likely <grant.likely@linaro.org>
> >> > >Cc: Rob Herring <robh+dt@kernel.org>
> >> > >Cc: Pawel Moll <pawel.moll@arm.com>
> >> > >Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> >> > >Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >> > >Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> >> >
> >> > I assume one of you will pick this up if there are no further comments ?
> >>
> >> I will once things settle down...
> >
> > I've picked it up. Yell if you'd prefer to take it by your tree.
> 
> Greg already applied it. It just hit Linus' tree Sat.

Yeah, I only just saw that today. I'll drop it from mine.

g.