From: Shawn Guo <shawnguo@kernel.org>
To: Bintian Wang <bintian.wang@huawei.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
will.deacon@arm.com, devicetree@vger.kernel.org,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
khilman@linaro.org, mturquette@linaro.org,
rob.herring@linaro.org, zhangfei.gao@linaro.org,
haojian.zhuang@linaro.org, xuwei5@hisilicon.com,
jh80.chung@samsung.com, olof@lixom.net, yanhaifeng@gmail.com,
sboyd@codeaurora.org, xuejiancheng@huawei.com,
sledge.yanwei@huawei.com, tomeu.vizoso@collabora.com,
linux@arm.linux.org.uk, guodong.xu@linaro.org,
jorge.ramirez-ortiz@linaro.org, tyler.baker@linaro.org,
khilman@kernel.org, pebolle@tiscali.nl, arnd@arndb.de,
marc.zyngier@arm.com, dan.zhao@hisilicon.com,
huxinwei@huawei.com, xuyiping@hisilicon.com,
wangbintian@gmail.com, victor.lixin@hisilicon.com,
puck.chen@hisilicon.com, wangbinghui@hisilicon.com,
zhenwei.wang@hisilicon.com, liguozhu@hisilicon.com,
kong.kongxinwei@hisilicon.com, heyunlei@huawei.com,
w.f@huawei.com, z.liuxinliang@huawei.com
Subject: Re: [PATCH v9 5/6] arm64: dts: Add dts files for Hisilicon Hi6220 SoC
Date: Tue, 9 Jun 2015 08:55:21 +0800 [thread overview]
Message-ID: <20150609005521.GA21682@tiger> (raw)
In-Reply-To: <1432950661-23060-6-git-send-email-bintian.wang@huawei.com>
A minor random comment below.
On Sat, May 30, 2015 at 09:51:00AM +0800, Bintian Wang wrote:
> + ao_ctrl: ao_ctrl {
> + compatible = "hisilicon,hi6220-aoctrl", "syscon";
> + reg = <0x0 0xf7800000 0x0 0x2000>;
> + #clock-cells = <1>;
> + };
> +
> + sys_ctrl: sys_ctrl {
> + compatible = "hisilicon,hi6220-sysctrl", "syscon";
> + reg = <0x0 0xf7030000 0x0 0x2000>;
> + #clock-cells = <1>;
> + };
> +
> + media_ctrl: media_ctrl {
> + compatible = "hisilicon,hi6220-mediactrl", "syscon";
> + reg = <0x0 0xf4410000 0x0 0x1000>;
> + #clock-cells = <1>;
> + };
> +
> + pm_ctrl: pm_ctrl {
An unit-address should be coded in the node name, when it has a 'reg'
property.
Shawn
> + compatible = "hisilicon,hi6220-pmctrl", "syscon";
> + reg = <0x0 0xf7032000 0x0 0x1000>;
> + #clock-cells = <1>;
> + };
next prev parent reply other threads:[~2015-06-09 0:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-30 1:50 [PATCH v9 0/6] arm64,hi6220: Enable Hisilicon Hi6220 SoC Bintian Wang
2015-05-30 1:50 ` [PATCH v9 1/6] arm64: Enable Hisilicon ARMv8 SoC family in Kconfig and defconfig Bintian Wang
2015-05-30 1:50 ` [PATCH v9 2/6] arm64: hi6220: Document devicetree bindings for Hisilicon hi6220 SoC Bintian Wang
2015-06-04 4:36 ` Rob Herring
2015-06-04 7:23 ` Bintian
2015-05-30 1:50 ` [PATCH v9 3/6] clk: hi6220: Document devicetree bindings for hi6220 clock Bintian Wang
2015-05-30 1:50 ` [PATCH v9 4/6] Documentation: DT: PL011: hi6220: add compatible string for Hisilicon designed UART Bintian Wang
2015-06-02 8:59 ` Linus Walleij
2015-06-02 9:13 ` Marc Zyngier
2015-06-02 9:43 ` Russell King - ARM Linux
2015-06-02 10:55 ` Bintian
2015-06-02 11:24 ` Russell King - ARM Linux
2015-06-02 11:46 ` Bintian
2015-05-30 1:51 ` [PATCH v9 5/6] arm64: dts: Add dts files for Hisilicon Hi6220 SoC Bintian Wang
2015-06-03 3:10 ` Bintian
2015-06-09 0:55 ` Shawn Guo [this message]
2015-06-09 1:39 ` Bintian
2015-06-09 2:30 ` Bintian
2015-05-30 1:51 ` [PATCH v9 6/6] dt-bindings: Add header file of hi6220 clock driver Bintian Wang
2015-06-02 0:14 ` [PATCH v9 0/6] arm64,hi6220: Enable Hisilicon Hi6220 SoC Kevin Hilman
2015-06-02 3:57 ` Bintian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150609005521.GA21682@tiger \
--to=shawnguo@kernel.org \
--cc=arnd@arndb.de \
--cc=bintian.wang@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=dan.zhao@hisilicon.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=guodong.xu@linaro.org \
--cc=haojian.zhuang@linaro.org \
--cc=heyunlei@huawei.com \
--cc=huxinwei@huawei.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jh80.chung@samsung.com \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=khilman@kernel.org \
--cc=khilman@linaro.org \
--cc=kong.kongxinwei@hisilicon.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=pebolle@tiscali.nl \
--cc=puck.chen@hisilicon.com \
--cc=rob.herring@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sledge.yanwei@huawei.com \
--cc=tomeu.vizoso@collabora.com \
--cc=tyler.baker@linaro.org \
--cc=victor.lixin@hisilicon.com \
--cc=w.f@huawei.com \
--cc=wangbinghui@hisilicon.com \
--cc=wangbintian@gmail.com \
--cc=will.deacon@arm.com \
--cc=xuejiancheng@huawei.com \
--cc=xuwei5@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=yanhaifeng@gmail.com \
--cc=z.liuxinliang@huawei.com \
--cc=zhangfei.gao@linaro.org \
--cc=zhenwei.wang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).