From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932149AbbFIDDn (ORCPT ); Mon, 8 Jun 2015 23:03:43 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:36131 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbbFIDDf (ORCPT ); Mon, 8 Jun 2015 23:03:35 -0400 Date: Tue, 9 Jun 2015 12:03:27 +0900 From: Tejun Heo To: Jeff Moyer Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, vgoyal@redhat.com, avanzini.arianna@gmail.com Subject: Re: [PATCHSET block/for-4.2/writeback] block, cgroup: make cfq charge async IOs to the appropriate blkcgs Message-ID: <20150609030327.GL21465@mtj.duckdns.org> References: <1433753973-23684-1-git-send-email-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey, Jeff. On Mon, Jun 08, 2015 at 03:49:56PM -0400, Jeff Moyer wrote: > Assuming you're ok with dropping patch 5, I'll review patches 6-8 once I'll update it to use GPF_NOWAIT. Can't drop it easily as that would complicate group lookup more complicated w/ pinning and all. > they've been reworked to account for that. I took a look at them, and > they look OK to me. But, if they are going to change, I'd rather wait > to ack the final versions. Hmm... the changes will be simple s/GFP_ATOMIC/GFP_NOWAIT. Shouldn't affect reviewing, I think. Thanks. -- tejun