From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964789AbbFILzo (ORCPT ); Tue, 9 Jun 2015 07:55:44 -0400 Received: from lists.s-osg.org ([54.187.51.154]:38636 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753887AbbFILyv (ORCPT ); Tue, 9 Jun 2015 07:54:51 -0400 Date: Tue, 9 Jun 2015 08:54:42 -0300 From: Mauro Carvalho Chehab To: lukasz.anaczkowski@intel.com Cc: dougthompson@xmission.com, bp@alien8.de, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Luck , Aristeu Rozanski Subject: Re: [PATCH 0/3] EDAC: add DDR4 flag, misc improvements Message-ID: <20150609085442.4ce53e78@recife.lan> In-Reply-To: <1433850192-9866-1-git-send-email-lukasz.anaczkowski@intel.com> References: <1433850192-9866-1-git-send-email-lukasz.anaczkowski@intel.com> Organization: Samsung X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lukasz, Em Tue, 9 Jun 2015 13:43:09 +0200 lukasz.anaczkowski@intel.com escreveu: > From: Lukasz Anaczkowski > > Series of patches that makes sb_edac more flexible for adding > support for future platforms. > > Jim Snow (3): > EDAC: add DDR4 flag > sb_edac: virtualize several hard-coded functions > sb_edac: support for duplicate device IDs > > drivers/edac/sb_edac.c | 95 ++++++++++++++++++++++++++++++++++++++++---------- > include/linux/edac.h | 6 ++-- > 2 files changed, 80 insertions(+), 21 deletions(-) The patches look interesting, but, specially in the case of patch 3/3, it is hard to review them without the patches that add support for future platforms that require multi-bus. I can't, for example, understand, so far, the need of "allow_dups" function parameter for sbridge_get_all_devices(). So, I'd like to see this patch series together with the patches adding support for those new "multi-bus" platforms. Thanks, Mauro