Re: [tpmdd-devel] [PATCH v2] tpm: introduce struct tpm_buf

[Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>]

On Tue, Jun 09, 2015 at 12:32:57PM +0200, Peter Huewe wrote:
> 
> 
> Hi
> 
> >> > +static inline void tpm_buf_store(struct tpm_buf *buf,
> >> > +				 unsigned int pos,
> >> > +				 const unsigned char *data,
> >> > +				 unsigned int len)
> >> > +{
> >> > +	BUG_ON((pos + len) > TPM_BUF_SIZE);
> >> > +
> >> > +	memcpy(&buf->data[pos], data, len);
> >> > +}
> >> 
> >> Don't you have to update the ->length here?
> >
> >No. Store is for placing value in position, not appending to the end.
> >
> Then either add a length check (whether ->length is big enough) and/or
> call the function "update"

There is a length check in the beginning (first line of the function
body).

> Peter

/Jarkko