From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933045AbbFIPTz (ORCPT ); Tue, 9 Jun 2015 11:19:55 -0400 Received: from mga09.intel.com ([134.134.136.24]:3421 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753816AbbFIPT0 (ORCPT ); Tue, 9 Jun 2015 11:19:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,581,1427785200"; d="scan'208";a="584772955" Date: Tue, 9 Jun 2015 18:19:19 +0300 From: Jarkko Sakkinen To: "Moore, Robert" Cc: "Zheng, Lv" , "Wysocki, Rafael J" , Len Brown , "open list:ACPI COMPONENT AR..." , "open list:ACPI COMPONENT AR..." , open list Subject: Re: [PATCH] acpi: update struct acpi_table_tpm2 Message-ID: <20150609151919.GA4453@jsakkine-mobl1> References: <1433770706-3332-1-git-send-email-jarkko.sakkinen@linux.intel.com> <94F2FBAB4432B54E8AACC7DFDE6C92E37D2F28EC@ORSMSX112.amr.corp.intel.com> <20150609091757.GB4968@jsakkine-mobl1> <94F2FBAB4432B54E8AACC7DFDE6C92E37D2F2BE7@ORSMSX112.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E37D2F2BE7@ORSMSX112.amr.corp.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 09, 2015 at 02:21:12PM +0000, Moore, Robert wrote: > ACPICA usually defines any "related" data structures, just for user > convenience. If you want to keep it, it's fine for me but we still probably use the internal structure for it in tpm_crb driver (as tpm_tis uses internal structure for CRB). Do other updates look fine? I'm looking into migrating to tpm_crb driver to use actbl3.h. /Jarkko > > > -----Original Message----- > > From: Jarkko Sakkinen [mailto:jarkko.sakkinen@linux.intel.com] > > Sent: Tuesday, June 09, 2015 2:18 AM > > To: Moore, Robert > > Cc: Zheng, Lv; Wysocki, Rafael J; Len Brown; open list:ACPI COMPONENT > > AR...; open list:ACPI COMPONENT AR...; open list > > Subject: Re: [PATCH] acpi: update struct acpi_table_tpm2 > > > > On Mon, Jun 08, 2015 at 08:52:02PM +0000, Moore, Robert wrote: > > > It looks like there is a change to the TCPA table also. > > > > Right. I'll update that too. > > > > I strongly think that the struct acpi_tpm2_control should not be in > > actbl3.h. It is not defined in the TCG ACPI specification. It is defined > > in > > > > http://www.trustedcomputinggroup.org/resources/pc_client_platform_tpm_prof > > ile_ptp_specification > > > > FIFO control structures are internal for to the TPM subsystem and so > > should be CRB control structures (and we have already inside tpm_crb.c). > > > > The structure ended up there probably because it was combined with the > > TPM2 table in that Microsoft specification. > > > > /Jarkko