From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753961AbbFIQNx (ORCPT ); Tue, 9 Jun 2015 12:13:53 -0400 Received: from mga03.intel.com ([134.134.136.65]:12894 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752521AbbFIQNp (ORCPT ); Tue, 9 Jun 2015 12:13:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,581,1427785200"; d="scan'208";a="743713409" Date: Tue, 9 Jun 2015 19:13:40 +0300 From: Jarkko Sakkinen To: "Moore, Robert" Cc: "Zheng, Lv" , "Wysocki, Rafael J" , Len Brown , "open list:ACPI COMPONENT AR..." , "open list:ACPI COMPONENT AR..." , open list Subject: Re: [PATCH] acpi: update struct acpi_table_tpm2 Message-ID: <20150609161340.GA7762@jsakkine-mobl1> References: <1433770706-3332-1-git-send-email-jarkko.sakkinen@linux.intel.com> <94F2FBAB4432B54E8AACC7DFDE6C92E37D2F28EC@ORSMSX112.amr.corp.intel.com> <20150609091757.GB4968@jsakkine-mobl1> <94F2FBAB4432B54E8AACC7DFDE6C92E37D2F2BE7@ORSMSX112.amr.corp.intel.com> <20150609151919.GA4453@jsakkine-mobl1> <20150609154230.GA5750@jsakkine-mobl1> <94F2FBAB4432B54E8AACC7DFDE6C92E37D2F2C83@ORSMSX112.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E37D2F2C83@ORSMSX112.amr.corp.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 09, 2015 at 04:12:52PM +0000, Moore, Robert wrote: > Well, you don't have to use it. ACPICA has done this in several other > places. Anyway, I'm hesitant to just remove it at this point. OK, understood. I'll send you an updated patch without the removal. /Jarkko > > -----Original Message----- > > From: Jarkko Sakkinen [mailto:jarkko.sakkinen@linux.intel.com] > > Sent: Tuesday, June 09, 2015 8:43 AM > > To: Moore, Robert > > Cc: Zheng, Lv; Wysocki, Rafael J; Len Brown; open list:ACPI COMPONENT > > AR...; open list:ACPI COMPONENT AR...; open list > > Subject: Re: [PATCH] acpi: update struct acpi_table_tpm2 > > > > On Tue, Jun 09, 2015 at 06:19:19PM +0300, Jarkko Sakkinen wrote: > > > On Tue, Jun 09, 2015 at 02:21:12PM +0000, Moore, Robert wrote: > > > > ACPICA usually defines any "related" data structures, just for user > > > > convenience. > > > > > > If you want to keep it, it's fine for me but we still probably use the > > > internal structure for it in tpm_crb driver (as tpm_tis uses internal > > > structure for CRB). > > > > Let me open this a little bit. Everytime we want to do some small change > > to control area (lets say TCG adds some flag) we would have to cycle them > > through you. > > > > And the changes are not coupled with ACPI in any possible way. This is > > only adds more maintenance burden to you and also to us. This structure is > > the main control structure for the CRB driver and will be refined many > > times in the future. There is no any kind of use to its fields outside of > > the CRB driver. > > > > /Jarkko