From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932808AbbFJFxf (ORCPT ); Wed, 10 Jun 2015 01:53:35 -0400 Received: from mga01.intel.com ([192.55.52.88]:9312 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752639AbbFJFx3 (ORCPT ); Wed, 10 Jun 2015 01:53:29 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,586,1427785200"; d="scan'208";a="744079676" Date: Wed, 10 Jun 2015 08:53:25 +0300 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: peterhuewe@gmx.de, Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH] tpm, tpm_crb: fix le64_to_cpu conversions in crb_acpi_add() Message-ID: <20150610055325.GA5731@jsakkine-mobl1> References: <1433849809-823-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20150609162240.GA7347@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150609162240.GA7347@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 09, 2015 at 10:22:40AM -0600, Jason Gunthorpe wrote: > On Tue, Jun 09, 2015 at 02:36:49PM +0300, Jarkko Sakkinen wrote: > > Needs a commit message, bug description, Fixes: header and does it go > to -stable ? > > > Reported-by: Matt Fleming > > Signed-off-by: Jarkko Sakkinen > > drivers/char/tpm/tpm_crb.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Obviously there is a problem here with the double swap. But that > should be a nop on x86 hardware, I didn't think there was a BE arch > using ACPI?? No but I don't want to write CRB driver assuming that CRB will be only used on LE platform like x86 even though current HW implementations are only on x86. > Reviewed-By: Jason Gunthorpe > > Jason /Jarkko