From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754219AbbFJHgN (ORCPT ); Wed, 10 Jun 2015 03:36:13 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:45847 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752696AbbFJHgE (ORCPT ); Wed, 10 Jun 2015 03:36:04 -0400 Date: Wed, 10 Jun 2015 00:36:03 -0700 From: Christoph Hellwig To: Ming Lei Cc: linux-kernel@vger.kernel.org, Dave Kleikamp , Jens Axboe , Zach Brown , Christoph Hellwig , Maxim Patlasov , Andrew Morton , Alexander Viro , Tejun Heo , Dave Chinner Subject: Re: [PATCH v5 2/5] block: loop: set QUEUE_FLAG_NOMERGES for request queue of loop Message-ID: <20150610073603.GB6964@infradead.org> References: <1433857766-6153-1-git-send-email-ming.lei@canonical.com> <1433857766-6153-3-git-send-email-ming.lei@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433857766-6153-3-git-send-email-ming.lei@canonical.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 09, 2015 at 09:49:23PM +0800, Ming Lei wrote: > It doesn't make sense to enable merge because the I/O > submitted to backing file is handled page by page. Looks fine, but does it make any difference?