From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755219AbbFKUkK (ORCPT ); Thu, 11 Jun 2015 16:40:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55288 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755164AbbFKUkH (ORCPT ); Thu, 11 Jun 2015 16:40:07 -0400 Date: Thu, 11 Jun 2015 13:40:06 -0700 From: Andrew Morton To: Joe Perches Cc: linux-kernel@vger.kernel.org Subject: diffs in changelogs Message-Id: <20150611134006.9df79a893e3636019ad2759e@linux-foundation.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org People often put diff snippets in changelogs. This causes problems when one tries to apply a file containing both the changelog and the diff because patch(1) tries to apply the diff which it found in the changelog. eg, something like git show d24a6e1087030b6da | patch -p1 will go haywire. So can we please have a checkpatch test warning people away from doing this? patch(1) seems to be really promiscuous in its detection of a patch. I haven't had much success searching for "^--- " and similar. What works best for me is searching for "^[whitespace]@@ -". Thanks.