From: Peter Zijlstra <peterz@infradead.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, adrian.hunter@intel.com,
x86@kernel.org, hpa@zytor.com, acme@infradead.org
Subject: Re: [PATCH 2/2] perf/x86/intel: Fix PMI handling for Intel PT
Date: Thu, 11 Jun 2015 16:00:20 +0200 [thread overview]
Message-ID: <20150611140020.GU19282@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1434024837-9916-3-git-send-email-alexander.shishkin@linux.intel.com>
On Thu, Jun 11, 2015 at 03:13:57PM +0300, Alexander Shishkin wrote:
> @@ -1426,7 +1426,23 @@ perf_event_nmi_handler(unsigned int cmd, struct pt_regs *regs)
> u64 finish_clock;
> int ret;
>
> - if (!atomic_read(&active_events))
> + /*
> + * Intel PT is a separate PMUs, it doesn't increment active_events
> + * nor does it use resources associated with it, such as DS area.
> + * However, it still uses the same PMI handler, so here we need
> + * to make sure to call it *also* if any PT events are present.
> + *
> + * BTS events currently increment active_events implicitly through
> + * x86_reserve_hardware(), where it acts as DS area reference
> + * counter, so no need to check x86_lbr_exclusive_bts counter here;
> + * otherwise we'd have to do the same for BTS.
> + *
> + * Theoretically, they could be made into separate PMI handlers, but
> + * that can create additional challenges as PT uses the same PMI status
> + * register as x86_pmu.
> + */
> + if (!atomic_read(&active_events) &&
> + !atomic_read(&x86_pmu.lbr_exclusive[x86_lbr_exclusive_pt]))
> return NMI_DONE;
>
Urgh, sad. That's two cache misses instead of one. Cant we somehow keep
that a single value to read?
next prev parent reply other threads:[~2015-06-11 14:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 12:13 [PATCH 0/2] perf/x86/intel: Fixes for PT and BTS Alexander Shishkin
2015-06-11 12:13 ` [PATCH 1/2] perf/x86/intel/bts: Fix DS area sharing with x86_pmu events Alexander Shishkin
2015-06-19 17:58 ` [tip:perf/urgent] " tip-bot for Alexander Shishkin
2015-06-11 12:13 ` [PATCH 2/2] perf/x86/intel: Fix PMI handling for Intel PT Alexander Shishkin
2015-06-11 14:00 ` Peter Zijlstra [this message]
2015-06-12 9:08 ` Alexander Shishkin
2015-06-12 13:09 ` Peter Zijlstra
2015-06-19 17:58 ` [tip:perf/urgent] " tip-bot for Alexander Shishkin
2015-06-24 12:21 ` Peter Zijlstra
2015-06-24 13:16 ` Peter Zijlstra
2015-06-24 14:47 ` Peter Zijlstra
2015-07-01 6:57 ` [tip:perf/urgent] perf/x86: Fix 'active_events' imbalance tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150611140020.GU19282@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@infradead.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).