From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753168AbbFLVVC (ORCPT ); Fri, 12 Jun 2015 17:21:02 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:47446 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750856AbbFLVU7 (ORCPT ); Fri, 12 Jun 2015 17:20:59 -0400 Date: Fri, 12 Jun 2015 14:20:58 -0700 (PDT) Message-Id: <20150612.142058.1085284048217032168.davem@davemloft.net> To: Jason@zx2c4.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netdevice: add netdev_pub helper function From: David Miller In-Reply-To: <1434115829-22804-1-git-send-email-Jason@zx2c4.com> References: <1434115829-22804-1-git-send-email-Jason@zx2c4.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 12 Jun 2015 14:20:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Jason A. Donenfeld" Date: Fri, 12 Jun 2015 15:30:29 +0200 > Being able to utilize this makes much code a lot simpler and cleaner. > It's a nice convenience function. > > Signed-off-by: Jason A. Donenfeld Please do not ever submit patches adding new interfaces without also submitting changes showing actual uses of the new interface. Otherwise it's impossible to see how really useful it actually is. I'm not applying this until you do so, thanks.