From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755544AbbFLSGn (ORCPT ); Fri, 12 Jun 2015 14:06:43 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57541 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754552AbbFLSGm (ORCPT ); Fri, 12 Jun 2015 14:06:42 -0400 Date: Fri, 12 Jun 2015 11:06:41 -0700 From: Greg KH To: David Vrabel Cc: Juergen Gross , xen-devel@lists.xensource.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com Subject: Re: [Xen-devel] [Patch V2 2/3] usb: Introduce Xen pvUSB frontend Message-ID: <20150612180641.GB23012@kroah.com> References: <1434118201-25617-1-git-send-email-jgross@suse.com> <1434118201-25617-3-git-send-email-jgross@suse.com> <20150612162007.GC15911@kroah.com> <557B09EA.6000503@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <557B09EA.6000503@citrix.com> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 12, 2015 at 05:33:46PM +0100, David Vrabel wrote: > On 12/06/15 17:20, Greg KH wrote: > > On Fri, Jun 12, 2015 at 04:10:00PM +0200, Juergen Gross wrote: > >> Introduces the Xen pvUSB frontend. With pvUSB it is possible for a Xen > >> domU to communicate with a USB device assigned to that domU. The > >> communication is all done via the pvUSB backend in a driver domain > >> (usually Dom0) which is owner of the physical device. > >> > >> The code is taken from the pvUSB implementation in Xen done by Fujitsu > >> based on Linux kernel 2.6.18. > >> > >> Changes from the original version are: > >> - port to upstream kernel > >> - put all code in just one source file > >> - move module to appropriate location in kernel tree > >> - adapt to Linux style guide > >> - minor code modifications to increase readability > >> > >> Signed-off-by: Juergen Gross > >> --- > >> drivers/usb/Kconfig | 2 + > >> drivers/usb/Makefile | 2 + > >> drivers/usb/xen/Kconfig | 10 + > >> drivers/usb/xen/Makefile | 5 + > >> drivers/usb/xen/xen-usbfront.c | 1647 ++++++++++++++++++++++++++++++++++++++++ > > > > A subdirectory for a single file? That seems like overkill, don't you > > think? As this is a USB "host" driver, why not put it in that > > directory? > > > > Also, last time these patches were posted, people asked why you can't > > use libusb/usbfs instead, what happened with that? Or usbip? > > Using libusb was for the backend driver. This frontend driver is a host > controller (which is why it should be drivers/usb/host/xen-pv-hcd.c or > similar). Then document the heck out of that please.