Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Stefan Agner <stefan@agner.ch>
Cc: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
	dwmw2@infradead.org, computersforpeace@gmail.com,
	mark.rutland@arm.com, boris.brezillon@free-electrons.com,
	aaron@tastycactus.com, marb@ixxat.de, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, robh+dt@kernel.org,
	linux-mtd@lists.infradead.org, kernel@pengutronix.de,
	galak@codeaurora.org, shawn.guo@linaro.org,
	linux-arm-kernel@lists.infradead.org, bpringlemeir@nbsps.com
Subject: Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others
Date: Fri, 12 Jun 2015 21:44:39 +0200	[thread overview]
Message-ID: <20150612194439.GA15327@breakpoint.cc> (raw)
In-Reply-To: <16ebb290641f700f2262527f90ff1e46@agner.ch>

On 2015-06-09 22:31:07 [+0200], Stefan Agner wrote:
> > have the endian swap. So an abstraction like you provided earlier
> > would be nice :)
> 
> What do you mean by that?

Something like you did for the reader where you have:

|static inline u32 vf610_nfc_read(struct vf610_nfc *nfc, uint reg)
|{
|	return readl(nfc->regs + reg);
|}

instead using readl() directly. So you could also have

|static inline u32 vf610_nfc_read_relaxed(struct vf610_nfc *nfc, uint reg)
|{
|	return readl_relaxed(nfc->regs + reg);
|}

Instead of using readl_relaxed(). Unless I'm mistaken, that function was
used more than once. If someone plugs in PPC support he does not need to
add this function anymore but but simply add an ifdef in vf610_nfc_read()
and vf610_nfc_read_relaxed() and replace it whatever works for him.

Sebastian