From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755312AbbFLR2P (ORCPT ); Fri, 12 Jun 2015 13:28:15 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:35711 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752617AbbFLR2M convert rfc822-to-8bit (ORCPT ); Fri, 12 Jun 2015 13:28:12 -0400 Date: Fri, 12 Jun 2015 20:28:09 +0300 From: Mihai =?UTF-8?B?RG9uyJt1?= To: Takashi Iwai Cc: Jonathan McDowell , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: Audio crackles with 4.1-rc1 Message-ID: <20150612202809.4ada983f@mdontu-l.dsd.bitdefender.biz> In-Reply-To: References: <20150502150513.GF10148@earth.li> <20150519161911.GD28070@earth.li> <20150519215310.GF28070@earth.li> <20150610131755.0b906783@mdontu-l.dsd.bitdefender.biz> <20150610134135.327e2bdc@mdontu-l.dsd.bitdefender.biz> <20150610144551.4578ee99@mdontu-l.dsd.bitdefender.biz> <20150610192202.0e987fd0@mdontu-l.dsd.bitdefender.biz> <20150610194303.3b82609d@mdontu-l.dsd.bitdefender.biz> <20150611011236.53bcd1fd@mdontu-l> <20150612012318.6e3482ed@mdontu-l> <20150612124523.37fd0875@mdontu-l> Organization: Home MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Jun 2015 16:13:16 +0200 Takashi Iwai wrote: > For your convenience, below is the combined patch for 4.1. > > Jonathan, could you also try this patch and see whether you still get > the noise? > > --- > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 0320cb523d9e..919051d92a0b 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -4515,6 +4515,8 @@ enum { > ALC288_FIXUP_DELL_HEADSET_MODE, > ALC288_FIXUP_DELL1_MIC_NO_PRESENCE, > ALC288_FIXUP_DELL_XPS_13_GPIO6, > + ALC292_FIXUP_DELL_E7X, > + ALC292_FIXUP_DISABLE_AAMIX, > }; > > static const struct hda_fixup alc269_fixups[] = { > @@ -5037,6 +5039,16 @@ static const struct hda_fixup alc269_fixups[] = { > .chained = true, > .chain_id = ALC288_FIXUP_DELL1_MIC_NO_PRESENCE > }, > + [ALC292_FIXUP_DISABLE_AAMIX] = { > + .type = HDA_FIXUP_FUNC, > + .v.func = alc_fixup_disable_aamix, > + }, > + [ALC292_FIXUP_DELL_E7X] = { > + .type = HDA_FIXUP_FUNC, > + .v.func = alc_fixup_dell_xps13, > + .chained = true, > + .chain_id = ALC292_FIXUP_DISABLE_AAMIX > + }, > }; > > static const struct snd_pci_quirk alc269_fixup_tbl[] = { > @@ -5049,6 +5061,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1025, 0x0775, "Acer Aspire E1-572", ALC271_FIXUP_HP_GATE_MIC_JACK_E1_572), > SND_PCI_QUIRK(0x1025, 0x079b, "Acer Aspire V5-573G", ALC282_FIXUP_ASPIRE_V5_PINS), > SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z), > + SND_PCI_QUIRK(0x1028, 0x05ca, "Dell Latitude E7240", ALC292_FIXUP_DELL_E7X), > + SND_PCI_QUIRK(0x1028, 0x05cb, "Dell Latitude E7440", ALC292_FIXUP_DELL_E7X), > SND_PCI_QUIRK(0x1028, 0x05da, "Dell Vostro 5460", ALC290_FIXUP_SUBWOOFER), > SND_PCI_QUIRK(0x1028, 0x05f4, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x1028, 0x05f5, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), > @@ -5637,8 +5651,7 @@ static int patch_alc269(struct hda_codec *codec) > > spec = codec->spec; > spec->gen.shared_mic_vref_pin = 0x18; > - if (codec->core.vendor_id != 0x10ec0292) > - codec->power_save_node = 1; > + codec->power_save_node = 1; > > snd_hda_pick_fixup(codec, alc269_fixup_models, > alc269_fixup_tbl, alc269_fixups); This patch works fine for me. You can add my Tested-by when you re-spin it for Linus and if Jonathan is happy as well. Thank you! -- Mihai Donțu